From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KCbwDJDx52DP5QAAgWs5BA (envelope-from ) for ; Fri, 09 Jul 2021 08:49:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GKWZCJDx52BzLAAAbx9fmQ (envelope-from ) for ; Fri, 09 Jul 2021 06:49:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A08A1CB71 for ; Fri, 9 Jul 2021 08:49:51 +0200 (CEST) Received: from localhost ([::1]:37744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1kKb-0002yn-EZ for larch@yhetil.org; Fri, 09 Jul 2021 02:49:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1kK3-0002wW-8k for emacs-orgmode@gnu.org; Fri, 09 Jul 2021 02:49:15 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:57837) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1kK1-0002sI-3G for emacs-orgmode@gnu.org; Fri, 09 Jul 2021 02:49:15 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id EDC9220004; Fri, 9 Jul 2021 06:49:08 +0000 (UTC) From: Nicolas Goaziou To: Allen Li Subject: Re: Bug: [PATCH] Use crm for tag completion [9.4.6 (9.4.6-gab9f2a @ /home/ionasal/.emacs.d/elpa/org-9.4.6/)] References: <80mtqw3vo0.fsf@felesatra.moe> Date: Fri, 09 Jul 2021 08:49:07 +0200 In-Reply-To: <80mtqw3vo0.fsf@felesatra.moe> (Allen Li's message of "Thu, 08 Jul 2021 22:26:07 -0700") Message-ID: <87sg0onfrw.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.200; envelope-from=mail@nicolasgoaziou.fr; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625813391; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=/YfVLgECrvk7l6wi3Gl+kA4gm1e/vYHTw6JVcuX0GLs=; b=IJ0hnjbBXdIIU7UODoHgXjhOpJmMQGQLqbbiE1huCUsrSZFdz3mdY81OVXPwey7TYfs9tW REPyMoJZLxnPx+5sdDJtbhAX6myTUfGcocdCIRkMbPHfWm1q1AQergK2Dz+mJMOSsLr0g0 829B9HdBf7eonrU9LP5LryRvjDkuUIGEFufYuJR71eRI6pfo/M+50/5xI6fNZTBHcsZfS8 SbyLmgKaieQe/IKwRJ0PGwaSzyFq81DQA4285g0jYvHyuAjAVBGH7fty9jagBsIPI4aACZ KKsypCqSupP+HPO0/rte1HxTC8ZjpjpWUj+RxB+9VhtG8egptqE+UvoSGD2meQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625813391; a=rsa-sha256; cv=none; b=ITJpRWMjq9/G3u0UKihi1vNDnogpYuUSXeGtjrqj7f5uiFPZw3fUrSQqntmXmkP/2tHwP2 vD8UsfdFPcSNi4sjmc39i8x7u/toxVo0mmj2EQ1YlRGGY578BXubvKGNEZRoYgHpD4agoG R80ecuQv/cPskH/dA14VHwxFZPYk0h2hr6bQAH5zPFqAt6X6I/pZBihDYfmUXdCL/F33m8 BN9bdM6B7xaQfDzXbwCQVuF3KuKOBc0XqLT+cWCVlhFTrLvZb2lk9X/80fjUET+LqQCwSZ s1eA1gYhpSYeW6NkXlNhphxM+nBKOQqovQ6jZ21KuM7vmXoc575voWCmp0z70Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.40 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 7A08A1CB71 X-Spam-Score: -2.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: kEpQZ5XiQBqR Hello, Allen Li writes: > * lisp/org-capture.el (org-capture-fill-template): Changed to use > completing-read-multiple. > * lisp/org.el (org-set-tags-command): Changed to use > completing-read-multiple. > (org-change-tag-in-region): Changed to use a simple completion table. > * testing/lisp/test-org.el (test-org/set-tags-command): Fixed tests. > * etc/ORG-NEWS (Tag completion now uses =completing-read-multiple=): > Added news. Applied. Thank you. I just changed string-join into to good ole mapconcat as the code base does not use subr-x.el Regards, -- Nicolas Goaziou