emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Allen Li <darkfeline@felesatra.moe>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: [PATCH] Use crm for tag completion [9.4.6 (9.4.6-gab9f2a @ /home/ionasal/.emacs.d/elpa/org-9.4.6/)]
Date: Fri, 09 Jul 2021 08:49:07 +0200	[thread overview]
Message-ID: <87sg0onfrw.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <80mtqw3vo0.fsf@felesatra.moe> (Allen Li's message of "Thu, 08 Jul 2021 22:26:07 -0700")

Hello,

Allen Li <darkfeline@felesatra.moe> writes:

> * lisp/org-capture.el (org-capture-fill-template): Changed to use
> completing-read-multiple.
> * lisp/org.el (org-set-tags-command): Changed to use
> completing-read-multiple.
> (org-change-tag-in-region): Changed to use a simple completion table.
> * testing/lisp/test-org.el (test-org/set-tags-command): Fixed tests.
> * etc/ORG-NEWS (Tag completion now uses =completing-read-multiple=):
> Added news.

Applied. Thank you.

I just changed string-join into to good ole mapconcat as the code base
does not use subr-x.el

Regards,
-- 
Nicolas Goaziou


      reply	other threads:[~2021-07-09  6:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09  5:26 Allen Li
2021-07-09  6:49 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg0onfrw.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=darkfeline@felesatra.moe \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: Bug: [PATCH] Use crm for tag completion [9.4.6 (9.4.6-gab9f2a @ /home/ionasal/.emacs.d/elpa/org-9.4.6/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).