From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4Bv6I2hQGGEJbQAAgWs5BA (envelope-from ) for ; Sun, 15 Aug 2021 01:23:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UL8XH2hQGGEMYwAA1q6Kng (envelope-from ) for ; Sat, 14 Aug 2021 23:23:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C67601543B for ; Sun, 15 Aug 2021 01:23:19 +0200 (CEST) Received: from localhost ([::1]:45284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mF2zm-0003rz-Rt for larch@yhetil.org; Sat, 14 Aug 2021 19:23:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mF2zN-0003rl-9U for emacs-orgmode@gnu.org; Sat, 14 Aug 2021 19:22:53 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:46688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mF2zL-0003Ax-Rx for emacs-orgmode@gnu.org; Sat, 14 Aug 2021 19:22:52 -0400 Received: by mail-pl1-x636.google.com with SMTP id u15so1057639plg.13 for ; Sat, 14 Aug 2021 16:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=wogTbpZ4QIItUadntyIrNegsCgOo5Dr/K6HP3iX+W38=; b=T5j13AXPSuorj+Wrlwnop9bnh0bs9u5FaK+m1pZ4ohSFi3tjDBWv51g0ktT8hKmhnu Cew38EuiFdZ16Mk6eolPoHVYl4q5JRJv/fHMh3hy5K/+8cFwcTF1GjjrWyvaMg/XIo5Z nVN4UF9Vlf+46KUrbGoAPP1s2X7dKveoMKucCtSM5eBKdsIAYDoaor7p0fMoKmVUwk8h QcmXHzjgt6us1wOO3r3SN0rAVoV9E27VJTPtQLPMyKV8GPRk8dTjZLxBLd5PzaAkFICI 7CjfrG/lXUwc4IqgFCyqqjva5gxCQXH4wC8M4UTjip0jjBFGhONca84yMq5Cnrn84SdI 2INw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=wogTbpZ4QIItUadntyIrNegsCgOo5Dr/K6HP3iX+W38=; b=ShiHQU2jyWpErE43pNRUoCDRUkOsxYZh13D2Raf+brhsHivCZYC83Ee1ahfY4FGwQy C056BYe+1n5JQ3zsdbzKEmXgJQHP13KpdFJWU9INTgvk/ecfkKAWIqbHyTHu+GWC8gEJ 1MF0CTMb1NQMY4RPDWiDYCWrnCrkFEUkl6nXVdMQYbFqK3FGhdevn5JsGWyRSsY7t/nu bzS7OOw4BJc6sF9Flj6InRrQzg24fVp+WanJF5X0KiXqfGYp9j/xMYoMutlGCSiDMI3c TgItTcTbYI7vWdSKU+us24sRQjYXynR4D744HNxotO2zHiEyCKElbkWwGWEfWsgVEYmR REbg== X-Gm-Message-State: AOAM5304AFNC0oSbXynwDTlVKwixKPZvbfOxfQJArccX3D0ZaWW51WPT IcZHMbiSA09IEJpRhsrheswLJYVtLvA= X-Google-Smtp-Source: ABdhPJzwKp+9svXE9BZUHzb4gRw9nzhPZUIaJ6qxcJNxA/cjEJv/1XO/HWoS0esDzup3gh70u+IO+w== X-Received: by 2002:a05:6a00:888:b029:3c3:ff1:38e with SMTP id q8-20020a056a000888b02903c30ff1038emr8818821pfj.17.1628983370233; Sat, 14 Aug 2021 16:22:50 -0700 (PDT) Received: from tim-desktop (106-69-114-139.dyn.iinet.net.au. [106.69.114.139]) by smtp.gmail.com with ESMTPSA id l126sm7912783pgl.14.2021.08.14.16.22.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Aug 2021 16:22:49 -0700 (PDT) References: <871r786qfe.fsf@gmail.com> User-agent: mu4e 1.6.3; emacs 28.0.50 From: Tim Cross To: emacs-orgmode@gnu.org Subject: Re: [PATCH] Rename headline to heading Date: Sun, 15 Aug 2021 09:19:09 +1000 In-reply-to: <871r786qfe.fsf@gmail.com> Message-ID: <87sfzbwr09.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=theophilusx@gmail.com; helo=mail-pl1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628983399; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=wogTbpZ4QIItUadntyIrNegsCgOo5Dr/K6HP3iX+W38=; b=AhKGV4gkbcJjS6F1loT/ZgW/bdhHIZJp3h91BqraF2Yd086zKUiNaKxb46Cucknv5iZhff X1wuRUqTCE1c4ifl2XZhym7jTCrB+No46KFZKf6q2cf5HIzLlln0shDUxlQZIyMeaWkybd 2qukYrrQt+WKTTlp/pF+dmXqRicjmePmixXym3YeNQ9TQF/qOXmqEniJm3um2yLwAnnrxk hwgDJXA3/B7YdKi58mxAk4wZcoqIAFiaY9Zn3drqtVCEBj15ZkV1GuP51dkVdjdGVQtCKv 7JRBA3ncSZXa6sU79TV3MMkhntXH06CUP6lPBQz98IimzN2XiS5ag2Z+EabViA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628983399; a=rsa-sha256; cv=none; b=lWk/O0hEzvU/MjQOkSXkUiy8KQCvpSBu2GovSHm9CefDb4QT9J0n/JE+OzEt1uA35eXqg3 RCSdknctY3LiSJnjAdYa1LOcbq+xL/dUlNS7G+3gK2suQoQDm/RZVW2ZedkIrFATZ3vkzw Hbq5mBoFvfMh0O8OXLeGh/d1UxnTiLUPSzlxQJso0+sbhWUb5jJgY0MfWOr9iypBCy5dDE SFWymYkfmoKUJKwzI6lxKhOzADsqWJoxKVWQ9n45Li7zzcCtG+CdAvcSN7i0aN/e9u/Njg kRJyNCSv1MUrAKdCi6Ngl8kF3DnDqicJYJWu8NChVnws9d51OpNRF84Rt2Qdwg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=T5j13AXP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=T5j13AXP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: C67601543B X-Spam-Score: -3.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: UfOIQOhVr7k/ this patch looks pretty good to me. My only suggestion is that the need to update capture templates be made more explicit in the NEWS.org file. I'm assuming this patch would only be applied to the next release and not maint branch. Probably important to try and apply this before the main branch moves on too much to avoid merge issues. While none of what is in the patch is terribly complex, it does have a lot of tough points and I imagine it could be fragile wrt underlying branch changes. Andr=C3=A9 A. Gomes writes: > Hi, > > As previously discussed, please find the patch below. > > I run the tests locally and they all pass. Let me know what you think. > > I'm still waiting for the FSF to send me back my form signed. I've sent > it on the 31st of July.