From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iA1NHfd3GWFF0gAAgWs5BA (envelope-from ) for ; Sun, 15 Aug 2021 22:24:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SE/DGPd3GWEdTwAA1q6Kng (envelope-from ) for ; Sun, 15 Aug 2021 20:24:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7BA61948F for ; Sun, 15 Aug 2021 22:24:19 +0200 (CEST) Received: from localhost ([::1]:56532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFMg5-0000pf-Pm for larch@yhetil.org; Sun, 15 Aug 2021 16:24:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFMfb-0000pO-3z for emacs-orgmode@gnu.org; Sun, 15 Aug 2021 16:23:47 -0400 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]:42754) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFMfZ-0000tn-FY for emacs-orgmode@gnu.org; Sun, 15 Aug 2021 16:23:46 -0400 Received: by mail-pj1-x1029.google.com with SMTP id mq2-20020a17090b3802b0290178911d298bso24169032pjb.1 for ; Sun, 15 Aug 2021 13:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:date:in-reply-to:message-id :mime-version; bh=Q4H0BwDsbW60sE4qudQRFvtG0VDqGm3/cKflu2QvC50=; b=kaSmW5sRHJrirNBq1Bk+EG/oR7nsKM/ekemuwkT7gikEdFvl/WVDvYSWWVyVTE80sP 5dc/Av5H5D80IlVX6yszv1yQt+md56mzSBBiECjhI6higdQb1bsarDXYGKiybdhXXasm 93V9UFmsPeRtaItAkT9zYHtrub4vQwrA713+qt3dP8JEjSY/CRK2+1LgePJvhWxGixFP s5XNbEJS8ARBF7cN1fm3iIKDYe555pW4T0UqucuM6oE8oTLZyu7J/ehQaVt2YkGiL6la UoT/xsa2g67Dsiu7lWMi3db/iQsXoBYPMC3YuZYQgzE9WHLSt28avDLleshcrZW3Sz5U tjhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject:date :in-reply-to:message-id:mime-version; bh=Q4H0BwDsbW60sE4qudQRFvtG0VDqGm3/cKflu2QvC50=; b=qxKnJv0O+aBJ40B4xBC2QQ+aabUxapEWxscyzpTZPXpYmKUbLLK13I4ayAQbWdV/3T hlqevQ+NuGfle9al4IYdl3PQcRu1N5Ualez7DocB5NnVNWO3HBXcOVB852l/CTCq/0RT 2mxJK9jtrtfth1ccoG8H2tHo2UvMkFHywcwgM51aPwmjMjO5ZpjxL1i/St6UoHRYGWIx 8aWRlz+dk0Csm4DN6lEXPoax0gkwNydx3w2jkYC3+sHds2HCxBBQ1/azWishBLFD+g7N YMWBbHzgDngRDxPQCR+aOoyi/KtNPVpzRIq++uRv7eq7l2kaomEgIlOU2C+65YKhPVMt EJBA== X-Gm-Message-State: AOAM531IEAkXS4YwczpWI29v/M+rQgVWPiHgpCHFwESqx+l8uGbVoc9p 9cNzMqMGPhzXktI5CKqJazBAD1iQ5sQ= X-Google-Smtp-Source: ABdhPJysKXQoCbcyrMbYsvUEIVxMrhNmx/Q57dcx+X9CfPA7M+wR08himUMIQK8fPqZQ/ykZlsye4A== X-Received: by 2002:a62:1616:0:b029:3e0:3447:59dd with SMTP id 22-20020a6216160000b02903e0344759ddmr12761688pfw.26.1629059023719; Sun, 15 Aug 2021 13:23:43 -0700 (PDT) Received: from tim-desktop (106-69-95-133.dyn.iinet.net.au. [106.69.95.133]) by smtp.gmail.com with ESMTPSA id c15sm8696643pfl.181.2021.08.15.13.23.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Aug 2021 13:23:43 -0700 (PDT) References: User-agent: mu4e 1.6.3; emacs 28.0.50 From: Tim Cross To: emacs-orgmode@gnu.org Subject: Re: Bug: `org-fill-paragraph' relies on M-q being bound to `fill-paragraph' [9.4.6 (9.4.6-12-gdcc3a8-elpa @ /home/mwj/.emacs.d/elpa/org-20210809/)] Date: Mon, 16 Aug 2021 06:18:13 +1000 In-reply-to: Message-ID: <87sfzacv91.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=theophilusx@gmail.com; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1629059060; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Q4H0BwDsbW60sE4qudQRFvtG0VDqGm3/cKflu2QvC50=; b=Pjyg7J4NfTt6dAaZ5RXRqbwGUlzyHNQLVQ+F9/82RwX6DqrCtsajbElAAQYpSKRUD1EZVm dyX13y4zlZBP/9AsI0/1DeDIrlPZOtaD60N/nU/LbKQJB5V+CNBMaeykDvPOzYYt23zAHb EIv09111gv//hrMUn+ljKQCfrbu/0DUNJgCEKiSoZo1RBkLNPQD1GcR70jxgw49yMBtcZT XV5NS+SHdlKfG0SPuxxEehvMEpRjOoOJZzd6qrDrKurDSsvAAVwfDgVdpbFng0r2MHsLMt Tr9/igVekh5VgwE8AuX6hyBnl9TKY1LYL8/A12HntOqOdFTQi9kZsBiuparUUg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1629059060; a=rsa-sha256; cv=none; b=M237/4f/I3QzLTOcRJNPam10mbH6p1nC9FX8gDvNJ5IGXjI5I/a1nXIzpyex5Upkrna/jP Xq8vqrtzHyIPn9CcRWK32+aEvxqjN7DsWxmMQ3ezkpFkKHx2xJvo56zCBdIk9txYRmE2mh POrkmCl/WA99alXo4kSaIdGgxdG0XJjYGEbd4DwOC9M9qiveb310l7pgH99LzhQpFpZQrg MuY+KxaGbZ+ppr+i3qezbdP/vZ6GI8fXdIdlHKufHo0dPx7w8VqNgtRSsQiF1le/E0PDLf 9VJa8i5v9c5VhrRH48TC4WVnATspy4X+2dvq8mFgmvX0B5/G6KnjRDxPj+gGjg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=kaSmW5sR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=kaSmW5sR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 7BA61948F X-Spam-Score: -3.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: M3lF75MLD2b1 This seems not only wrong, but also dangerous. I don't think org should make any assumptions about what is bound to a key, especially when talking about a key binding which is not an org binding. Consider what might occur if the user had rebound that key to something destructive. "Marvin J." writes: > If you globally rebind M-q, then `org-fill-paragraph' will not work > > properly anymore. > > The reason is that `org-fill-element' has the line > > (src-block (org-babel-do-key-sequence-in-edit-buffer (kbd "M-q"))) > > While of course M-q is the default binding for `fill-paragraph', org > > should respect that the user might want to change keybindings. > > Emacs : GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4) > > of 2021-08-13 > > Package: Org mode version 9.4.6 (9.4.6-12-gdcc3a8-elpa @ /home/mwj/.emacs.d/elpa/org-20210809/)