From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Re: Gnus link BUGS Date: Sun, 24 Dec 2006 01:54:58 +0100 Message-ID: <87r6uqf6zh.fsf@tallis.ilo.ucl.ac.uk> References: <87mz5g61kl.fsf@tallis.lumiere.ens.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GyHdo-0001Nk-Ni for emacs-orgmode@gnu.org; Sat, 23 Dec 2006 19:55:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GyHdl-0001KF-Qa for emacs-orgmode@gnu.org; Sat, 23 Dec 2006 19:55:03 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GyHdl-0001K9-K9 for emacs-orgmode@gnu.org; Sat, 23 Dec 2006 19:55:01 -0500 Received: from [193.252.22.22] (helo=smtp9.orange.fr) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GyHdl-0007q6-1b for emacs-orgmode@gnu.org; Sat, 23 Dec 2006 19:55:01 -0500 Received: from tallis (ALagny-155-1-38-190.w90-3.abo.wanadoo.fr [90.3.229.190]) by mwinf0901.orange.fr (SMTP Server) with ESMTP id 2C7F42001428 for ; Sun, 24 Dec 2006 01:54:59 +0100 (CET) In-Reply-To: (Leo's message of "Sat\, 23 Dec 2006 18\:23\:16 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi Leo, Leo writes: > It handles the case when article number is invalid. The patch you provided didn't work for me (see the backtrace below), but this one against org.el 4.60 does the job, please give it a try. Note that i'm not using `org-gnus-group-articles'. ====================================================================== --- org.el 2006/12/23 22:50:54 0.2 +++ org.el 2006/12/24 00:36:13 @@ -9046,14 +9046,11 @@ (require 'gnus) (funcall (cdr (assq 'gnus org-link-frame-setup))) (if gnus-other-frame-object (select-frame gnus-other-frame-object)) - (if group (gnus-fetch-group group)) - (if article - (or (gnus-summary-goto-article article nil 'force) - (if (fboundp 'gnus-summary-insert-cached-articles) - (progn - (gnus-summary-insert-cached-articles) - (gnus-summary-goto-article article nil 'force)) - (message "Message could not be found."))))) + (cond ((and group article) + (gnus-fetch-group group (list (string-to-number article))) + (gnus-summary-select-article)) + (group (gnus-group-jump-to-group group) + (gnus-group-select-group)))) (defun org-follow-vm-link (&optional folder article readonly) "Follow a VM link to FOLDER and ARTICLE." ====================================================================== Debugger entered--Lisp error: (wrong-type-argument sequencep 10) gnus-select-newsgroup("nnml:mail.esf" t 10) gnus-summary-read-group-1("nnml:mail.esf" t nil nil nil 10) gnus-summary-read-group("nnml:mail.esf" t nil nil nil nil 10) gnus-group-read-group(nil nil "nnml:mail.esf" 10) gnus-fetch-group("nnml:mail.esf" 10) (progn (gnus-fetch-group group org-gnus-group-articles) (when article (if ... ...) (and ... ...))) (if group (progn (gnus-fetch-group group org-gnus-group-articles) (when article ... ...))) (when group (gnus-fetch-group group org-gnus-group-articles) (when article (if ... ...) (and ... ...))) org-follow-gnus-link("nnml:mail.esf" "1371") (let (group article) (if (not ...) (error "Error in Gnus link")) (setq group (match-string 1 path) article (match-string 3 path)) (org-follow-gnus-link group article)) (cond ((equal type "mailto") (let ... ... ... ...)) ((member type ...) (browse-url ...)) ((string= type "tags") (org-tags-view in-emacs path)) ((or ... ...) (if in-emacs ... ...) (org-link-search path ...)) ((string= type "file") (if ... ... ...) (org-open-file path in-emacs line search)) ((string= type "news") (org-follow-gnus-link path)) ((string= type "bbdb") (org-follow-bbdb-link path)) ((string= type "info") (org-follow-info-link path)) ((string= type "gnus") (let ... ... ... ...)) ((string= type "vm") (let ... ... ... ...)) ((string= type "wl") (let ... ... ... ...)) ((string= type "mhe") (let ... ... ... ...)) ((string= type "rmail") (let ... ... ... ...)) ((string= type "shell") (let ... ... ... ...)) ((string= type "elisp") (let ... ...)) (t (browse-url-at-point))) (let (type path link line search (pos ...)) (catch (quote match) (save-excursion ... ...) (when ... ... ...) (save-excursion ... ... ...) (save-excursion ... ...) (save-excursion ... ... ...)) (unless path (error "No link found")) (if (string-match " +\\'" path) (setq path ...)) (cond (... ...) (... ...) (... ...) (... ... ...) (... ... ...) (... ...) (... ...) (... ...) (... ...) (... ...) (... ...) (... ...) (... ...) (... ...) (... ...) (t ...))) (if (org-at-timestamp-p t) (org-follow-timestamp-link) (let (type path link line search ...) (catch ... ... ... ... ... ...) (unless path ...) (if ... ...) (cond ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ...))) org-open-at-point(nil) call-interactively(org-open-at-point) -- Bastien