emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Matt Lundin <mdl@imapmail.org>
To: Eric Schulte <schulte.eric@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-bibtex.el --- convert between Org headings and bibtex entries
Date: Fri, 22 Apr 2011 20:03:52 -0400	[thread overview]
Message-ID: <87r58tdeaf.fsf@fastmail.fm> (raw)
In-Reply-To: <87r58uz3ux.fsf@fastmail.fm> (Matt Lundin's message of "Fri, 22 Apr 2011 11:45:58 -0400")

Matt Lundin <mdl@imapmail.org> writes:

> "Eric Schulte" <schulte.eric@gmail.com> writes:
>> As one possible solution to this name conflict, I've folded my
>> org-bibtex.el into the existing org-bibtex.el in the Org-mode core.  The
>> attached patch performs this integration adding the functionality in my
>> version of org-bibtex.el into the Org-mode core.
>>
>> Does this seem like an appropriate addition?
>
> +1 (or maybe +.75 -- see below)
>
> I think this could finally tempt me to move all my bibliographical data
> into org-mode files. (I've been keeping all my data in a central bibtex
> file and using reftex to generate links to citations.)

I've been testing the patch and have a few comments. 

1. The prompt for the completing-read on line 440 is missing a space. It
   shows "Type:" rather than "Type: ".

2. In addition, since the symbols in org-bibtex-types are keywords, the
   completions are in the form ":article", ":book", etc. Might I ask why
   everything is org-bibtex-type is a keyword? Could we use strings or
   plain symbols instead? (Note: I haven't read the code carefully
   enough to see if there is a reason.)

3. The tooltip/help pop-up for org-bibtex-create takes up half a frame.

Thanks,
Matt

  reply	other threads:[~2011-04-23  0:03 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-19 23:52 [ANN] org-bibtex.el --- convert between Org headings and bibtex entries Eric Schulte
2011-04-20  1:01 ` Jeff Horn
2011-04-20  1:13   ` Eric Schulte
2011-04-20  7:54 ` Thomas S. Dye
2011-04-20 13:25   ` Matt Lundin
2011-04-20 14:29     ` Matt Lundin
2011-04-20 19:59     ` Eric Schulte
2011-04-20 19:00   ` Eric Schulte
2011-04-21 16:36     ` Thomas S. Dye
2011-04-21 21:06       ` Eric Schulte
2011-04-23 16:23         ` Thomas S. Dye
2011-04-23 22:59           ` Alan E. Davis
2011-04-24  0:40             ` Matt Lundin
2011-04-24 14:21               ` Eric Schulte
2011-04-24 16:53                 ` Christian Moe
2011-04-25 13:19                   ` Matt Lundin
2011-04-25 13:34                     ` Eric Schulte
2011-04-25 15:15                 ` Matt Lundin
2011-04-27 22:16                   ` Eric Schulte
2011-04-24  0:52             ` Eric Schulte
2011-04-24  4:49               ` Alan E. Davis
2011-04-24 14:29                 ` Eric Schulte
2011-04-24 20:40                   ` Alan E. Davis
2011-04-25 13:31                     ` Eric Schulte
2011-04-20  9:26 ` Christian Moe
2011-04-20 20:15   ` Eric Schulte
2011-04-20 12:10 ` Matt Lundin
2011-04-20 20:16   ` Eric Schulte
2011-04-22 14:05   ` [PATCH] " Eric Schulte
2011-04-22 15:45     ` Matt Lundin
2011-04-23  0:03       ` Matt Lundin [this message]
2011-04-23 14:07         ` Eric Schulte
2011-04-23 22:46           ` Matt Lundin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r58tdeaf.fsf@fastmail.fm \
    --to=mdl@imapmail.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=schulte.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).