From: "Myles English" <mylesenglish@gmail.com>
To: Org mode <emacs-orgmode@gnu.org>
Subject: [PATCH] Fixing when org-clock-in-prepare-hook is called
Date: Fri, 26 Oct 2012 12:47:59 +0100 [thread overview]
Message-ID: <87r4olh2ts.fsf@ed.ac.uk> (raw)
From d7c3f0a4611ced0a240af9115f29f888beb60af2 Mon Sep 17 00:00:00 2001
From: Myles English <mylesenglish@gmail.com>
Date: Fri, 26 Oct 2012 12:38:09 +0100
Subject: [PATCH] Clocking: Move to task before calling
org-clock-in-prepare-hook
* lisp/org-clock.el (org-clock-in): Moved the call to
org-clock-in-prepare-hook until the task's properties
can be accessed.
The problem was when using a function to add an effort
property via the hook, it would not recognise an existing
effort property when called with the prefix (C-u C-c C-x C-i)
with the point at a place other than at the task.
TINYCHANGE
---
lisp/org-clock.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index e5488e4..84eb2fd 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -1149,7 +1149,6 @@ make this the default behavior.)"
(if (and (eobp) (not (org-at-heading-p)))
(point-at-bol 0)
(point)))
- (run-hooks 'org-clock-in-prepare-hook)
(save-excursion
(when (and selected-task (marker-buffer selected-task))
;; There is a selected task, move to the correct buffer
@@ -1168,6 +1167,7 @@ make this the default behavior.)"
;; beginning of the heading, since the
;; user is liking to insert stuff here
;; manually
+ (run-hooks 'org-clock-in-prepare-hook)
(org-clock-history-push))
(org-clock-set-current)
(cond ((functionp org-clock-in-switch-to-state)
--
1.8.0
next reply other threads:[~2012-10-26 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 11:47 Myles English [this message]
2012-10-26 11:50 ` [PATCH] Fixing when org-clock-in-prepare-hook is called Sebastien Vauban
2012-10-26 12:47 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4olh2ts.fsf@ed.ac.uk \
--to=mylesenglish@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).