emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: Daimrod <daimrod@gmail.com>
Cc: emacs-orgmode@gnu.org, Eric Schulte <schulte.eric@gmail.com>
Subject: Re: [PATCH] Add `org-reverse-string'
Date: Wed, 13 Feb 2013 16:33:38 +0100	[thread overview]
Message-ID: <87r4kkut2l.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87vcaj39w2.fsf@casa.home> (daimrod@gmail.com's message of "Sat, 26 Jan 2013 22:35:41 +0100")

Hi Daimrod,

Daimrod <daimrod@gmail.com> writes:

> Eric Schulte <schulte.eric@gmail.com> writes:
>
>> This patch looks fine to me, although you'll need to add a
>> `declare-function' call to the top of ob-core.el (and maybe to org-id as
>> well) or the compiler will complain.
>
> I've added a `declare-function' call to `ob-core.el' but I think I don't
> need to add it to `org-id.el' because it already require `org.el'.
>
> Thanks for taking time to review this patch.

I've applied this patch, thanks!

-- 
 Bastien

      reply	other threads:[~2013-02-13 15:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-26 20:44 [PATCH] Add `org-reverse-string' Daimrod
2013-01-26 21:02 ` Eric Schulte
2013-01-26 21:35   ` Daimrod
2013-02-13 15:33     ` Bastien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4kkut2l.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=daimrod@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=schulte.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).