From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: Warning with latest git pull
Date: Sat, 23 Feb 2013 12:21:27 +0100
Message-ID: <87r4k746o8.fsf@bzg.ath.cx>
References: <m1d2vuetmg.fsf@tsdye.com> <87a9qxl6bv.fsf@bzg.ath.cx>
	<87621jxu41.fsf@Rainer.invalid>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:48793)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1U9DAe-0000YT-OV
	for emacs-orgmode@gnu.org; Sat, 23 Feb 2013 06:21:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1U9DAY-0000KZ-TA
	for emacs-orgmode@gnu.org; Sat, 23 Feb 2013 06:21:36 -0500
Received: from mail-wg0-f49.google.com ([74.125.82.49]:36161)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1U9DAY-0000KJ-Nl
	for emacs-orgmode@gnu.org; Sat, 23 Feb 2013 06:21:30 -0500
Received: by mail-wg0-f49.google.com with SMTP id 15so1158669wgd.4
	for <emacs-orgmode@gnu.org>; Sat, 23 Feb 2013 03:21:30 -0800 (PST)
In-Reply-To: <87621jxu41.fsf@Rainer.invalid> (Achim Gratz's message of "Sat,
	23 Feb 2013 10:22:22 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org

Achim Gratz <Stromeko@nexgo.de> writes:

> Bastien writes:
>> Fixed, thanks!
>
> Uh… no, you switched the wrong function in the second line (which
> incidentally indicates that this branch of the conditional never sees
> any testing).  Fixed in master by using org-float-time.  

Indeed, thanks for fixing this.

> I checked in
> XEmacs 21.5 and it has float-time, so maybe we wouldn't need a
> compatibility function after all, but I don't know when XEmacs
> introduced float-time.

Mhh... the less compatibility functions the better.

I found this ChangeLog entry in XEmacs 21.5-b33:

2010-05-30  Aidan Kehoe  <kehoea@parhasard.net>

	* subr.el (float-time): Add this function, available in
	editfns.c in GNU.

And time-to-seconds seems absent -- but it seems absent from
*any* version of XEmacs I could check (21.4.1, 21.4.9, 21.5.9).

So yes, I think it's safe to remove this compat function.
Let me know if you find time-to-seconds in <2010 versions
of XEmacs.

Thanks,

-- 
 Bastien