emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Aaron Ecay <aaronecay@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH 0/3] synctex support for pdf export
Date: Mon, 01 Apr 2013 11:15:48 +0200	[thread overview]
Message-ID: <87r4iutxvf.fsf@gmail.com> (raw)
In-Reply-To: <1364786101-16603-1-git-send-email-aaronecay@gmail.com> (Aaron Ecay's message of "Sun, 31 Mar 2013 23:14:58 -0400")

Hello,

Aaron Ecay <aaronecay@gmail.com> writes:

> This patch series is an attempt to add synctex support to org mode.

Thank you for your patch.

> I have not tested this code extensively, but it does work for me.  I
> don't know if it works for async export or not, since I haven't set up
> a working environment for that.

Async export works out of-the-box (though not optimized). There's no
special environment to set up.

> There are currently limitations.  The granularity of the jumping is
> not great, because of the way the parser works.  It will get you into
> the paragraph corresponding to the PDF location, but no closer (with
> pure latex, you will arrive at the exact line in the tex file).  You
> also have to run org-latex-patch-synctex manually, unless you use the
> direct-to-pdf export option (C-c C-e l p).  In regular latex, beamer
> documents have somewhat degraded synctex granularity (in general, you
> don't get to the exact source line, but only somewhere between
> \begin{frame} and \end{frame}).  This may be compounded by the bad
> granularity of this patch -- I have not tested this combo very much.

[...]

As you notice, there are many limitations and I agree some of them will
be tedious to overcome. It also breaks asynchronous export.

Moreover, modifying both parser and core export framework for an
optional feature within a single back-end family is not right, IMO.

While I acknowledge the investment put into this patch, I won't accept
it in its current form. I might consider it if it only modifies
ox-latex.el, handles include keywords and buffer modifications through
Babel, and doesn't break asynchronous export. Not relying on text
properties is a real plus.

Though, don't push it too hard, I'm really not sure it's worth the
trouble.


Regards,

-- 
Nicolas Goaziou

  parent reply	other threads:[~2013-04-01  9:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01  3:14 [PATCH 0/3] synctex support for pdf export Aaron Ecay
2013-04-01  3:14 ` [PATCH 1/3] Add :begin-line and :end-line to parser results Aaron Ecay
2013-04-01  3:15 ` [PATCH 2/3] Introduce machinery to ox.el for concordance generation Aaron Ecay
2013-04-01  3:15 ` [PATCH 3/3] Add synctex modification based on concordance Aaron Ecay
2013-04-01  9:15 ` Nicolas Goaziou [this message]
2013-04-01 15:33   ` [PATCH 0/3] synctex support for pdf export Aaron Ecay
2013-04-04 13:19     ` Nicolas Goaziou
2013-04-18  8:29       ` Aaron Ecay
2013-04-18 16:27         ` Rasmus
2013-04-15  9:33   ` Andreas Leha
2013-04-15 11:50     ` Alan Schmitt
2013-04-15 15:37       ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4iutxvf.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=aaronecay@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).