From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daimrod Subject: Re: phone links... Date: Wed, 17 Apr 2013 00:22:14 +0200 Message-ID: <87r4iam7zd.fsf@tanger.home> References: <5156228C.4010400@sift.info> <871uaq7aqy.fsf@bzg.ath.cx> <515E3938.2030202@sift.info> <20130408103832.GE659@strey.biz> <5162BC78.7010509@sift.info> <20130408140731.GF659@strey.biz> <5162D7BC.3020303@sift.info> <20130409073140.GJ659@strey.biz> <20130414204929.GY659@strey.biz> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:59698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USEET-00063j-VT for emacs-orgmode@gnu.org; Tue, 16 Apr 2013 18:20:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USEES-0000nA-Mp for emacs-orgmode@gnu.org; Tue, 16 Apr 2013 18:20:09 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:39678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USEES-0000mr-GE for emacs-orgmode@gnu.org; Tue, 16 Apr 2013 18:20:08 -0400 Received: by mail-wg0-f50.google.com with SMTP id m15so1014515wgh.5 for ; Tue, 16 Apr 2013 15:20:07 -0700 (PDT) In-Reply-To: <20130414204929.GY659@strey.biz> (Michael Strey's message of "Sun, 14 Apr 2013 22:49:29 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Michael Strey writes: Hello Michael, > On Tue, Apr 09, 2013 at 09:31:40AM +0200, Michael Strey wrote: > > [...] > >> The problem is on the side of org-contacts. Org-contacts does not >> support links in its properties. > [...] > >> This shortcoming effects not only the phone links but email links as >> well. > > Attached is a patch to allow org links in org-contacts properties. > It allows entries like in the following example without effecting > org-contacts current functions. > > #+BEGIN_SRC org > * Surname, Name > :PROPERTIES: > :EMAIL: mailto:test2@test.de; [[mailto:name@test.de]] foo@bar.biz > :PHONE: [[tel:+49 351 4129535]], +491766626196 [[+49 (351) 41295-35]] > :END: > #+END_SRC > > Phone links of the form [[tel:+49 351 412 95-35][My phone number]] or > [[tel:+49 351 41295-35]] are expected. `-', `/', `(', `)' and > whitespace characters are allowed in telephone numbers. Thank you for your patch, though here are a few suggestions: =2D It looks like `chomp' does the same thing the `org-trim' (in `org.el') if so you should use it. =2D You should use `org-link-display-format' instead of `org-contacts-strip-link'. =2D You have done some unrelated changes (fix some typos, ...), could you provide a separated patches for them? Regarding `org-contacts-split-property', I haven't found anything about multiple values within a node property in `org-element' and the syntax description doesn't mention it, so you were right to roll your own. :) However, I think it would be better to store the separators in a variable (like `org-contacts-property-values-separator') and maybe even to use it by default instead of `split-string-default-separators' because we use it more and because it's easy to forget. > + (loop for email in (org-contacts-split-property email-li= st) = ^^^^ > + for gravatar =3D (gravatar-retrieve-synchronously = (org-contacts-strip-link email)) What do you think? Thanks again for your time! Regards, =2D-=20 Daimrod/Greg --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJRbc8WAAoJEBNzVHcrZRiUbOIP/3+eAebzk+aBt6YgktHDFrMs vbXCtKGKLybLNfaoee95ej/2Z5+7O6qOVWzE5+vpIjgvdkDnCE/zOHskANwTBowr L1et9IlQXIWM74EGoqiOH+f9FdrteAPf3rwMlZWcc3cWAWJoA6xkBurPfRqhKlNy IrkCMcM24c6Hg6p3B2otb2qykeie/jLdwXfWN/BQVlio1fzjRSjum96uL6J8b3H1 b/oiPrUG2vdQPYVVAUI3Sg3J2kKI02a6Ve5gYdpB6gE5rS/9dqO9LbldXlLCSUDo BbSMANT1BYEnLv9vsDZOaM9MbMBNYgF68TIiCmN1TU8JIgdHKAVvx2KeTDlSINsn yYd7CMGVQVhNYYHNMSVnz1NLK4jrQniMYbHABXYH7Blc5ZGWDHL/njo/6nJc5sXp kzoVNB2ughYa8VH++VdBPokN4Lj3ir1Uo974Wg68vjvjrnkhVJSomM4zwvfUl6An 3woN69imYwWXYTewhKbWfVpNsSThcv0K91CJF+1sCNCHoHqNTDDzM+SmEWcF42HV q63py0d6mnxEkJbrkkrpZx1Oh6eLtMKnMCZBVwDPucYj1JWfAyGJO1s+I9yhQC0P pgRORrot97WQqrGpVzF3OfNcP2OBTlqXwmXQRwt0iRX4tvVf48hNuZw8ca/Tzkxy dY7yF80NcMBL/JUfY2zx =FUzI -----END PGP SIGNATURE----- --=-=-=--