emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Thomas Holst <thomas.holst@de.bosch.com>
Cc: Myles English <mylesenglish@gmail.com>,
	Emacs-orgmode <Emacs-orgmode@gnu.org>,
	Carsten Domink <carsten.dominik@gmail.com>
Subject: Re: links to attachments don't export anymore
Date: Fri, 15 Nov 2013 18:35:31 +0100	[thread overview]
Message-ID: <87r4ahk1p8.fsf@gmail.com> (raw)
In-Reply-To: <87a9h5li6m.fsf@gmail.com> (Nicolas Goaziou's message of "Fri, 15 Nov 2013 17:54:09 +0100")

Nicolas Goaziou <n.goaziou@gmail.com> writes:

> Hello,
> Thomas Holst <thomas.holst@de.bosch.com> writes:
>> · Myles English <mylesenglish@gmail.com> wrote:
>> [ ... snip ... ]
>>> It was possible to insert a link to an attachment like this:
>>> [[att:FigureA.jpg]]
>>> and clicking on it would show the file (still works), and it would show
>>> up in the exported document (no longer happens).
>> [ ... snip ... ]
>> since I like this feature I'd like to give this thread a bump. With git
>> bisecting I found that commit:
>> 026b99ecb86e08f4fdc7b45ee2bfa1d4c84a37f6 is the first bad commit
>> commit 026b99ecb86e08f4fdc7b45ee2bfa1d4c84a37f6
>> Author: Nicolas Goaziou <n.goaziou@gmail.com>
>> Date:   Fri Aug 30 13:29:51 2013 +0200
> Since I have been proven guilty, let me add it to my TODO list.

Actually, this could solved by widening the buffer before expanding the
link in `org-element-link-parser'.

Though, I'm surprised that neither `org-id-get', `org-entry-get' nor, at
the most basic level, `org-entry-properties' remove narrowing before
computing their return value.

Is there any reason for this? AFAICT, it would be better to wrap them
with a `org-with-wide-buffer' macro.

Cc'ing Carsten before patching blindly.


Nicolas Goaziou

  reply	other threads:[~2013-11-15 17:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 17:18 links to attachments don't export anymore Myles English
2013-11-14 14:44 ` Thomas Holst
2013-11-15 16:54   ` Nicolas Goaziou
2013-11-15 17:35     ` Nicolas Goaziou [this message]
2013-11-18 19:57       ` Nicolas Goaziou
2013-11-19  7:15         ` Thomas Holst
2013-11-19 14:21           ` Myles English
2013-11-22 10:35           ` Thomas Holst
2013-11-22 11:46             ` Nicolas Goaziou
2013-11-25  9:05               ` Thomas Holst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4ahk1p8.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=Emacs-orgmode@gnu.org \
    --cc=carsten.dominik@gmail.com \
    --cc=mylesenglish@gmail.com \
    --cc=thomas.holst@de.bosch.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).