From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Morgan Subject: Re: Standard skipping conditions have no effect Date: Sun, 01 Jun 2014 21:00:34 -0400 Message-ID: <87r43886rx.fsf@azha.ziiuu.com> References: <874n04usgy.fsf@azha.ziiuu.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrGcF-0003N4-EZ for emacs-orgmode@gnu.org; Sun, 01 Jun 2014 21:00:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrGc9-0003MV-CT for emacs-orgmode@gnu.org; Sun, 01 Jun 2014 21:00:43 -0400 Received: from mail-qg0-f42.google.com ([209.85.192.42]:62644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrGc8-0003MO-Vq for emacs-orgmode@gnu.org; Sun, 01 Jun 2014 21:00:37 -0400 Received: by mail-qg0-f42.google.com with SMTP id q107so9758816qgd.15 for ; Sun, 01 Jun 2014 18:00:36 -0700 (PDT) Received: from azha.ziiuu.com (cpe-68-173-37-126.nyc.res.rr.com. [68.173.37.126]) by mx.google.com with ESMTPSA id 73sm7366196qgw.5.2014.06.01.18.00.35 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jun 2014 18:00:35 -0700 (PDT) In-Reply-To: <874n04usgy.fsf@azha.ziiuu.com> (Thomas Morgan's message of "Sun, 01 Jun 2014 19:21:01 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Attached are the files referred to in the bug report. Thomas Morgan writes: > Hello, Org mode hackers, > > Here is a recipe for a bug on the maint branch that causes standard > skipping conditions to have no effect. > > 1. Change the load path setting in `setup.el'. > > 2. Start Emacs with `emacs -Q -l setup.el'. > > 3. Customize the agenda commands with `M-x org-agenda C'. > > 4. Add a new command, change the match field to tag `foo', and add a > standard skipping condition for TODO states, so that the command > looks like this in the customization buffer: > > ,---- > | INS DEL Choice: Value Menu Single command: > | Access Key(s) : x > | [X] Description: Describe command here > | Choice: Value Menu Tags/Property match (all agenda files) > | Match (only for some commands): foo > | Local settings for this command. Remember to quote values: > | INS DEL Setting: Value Menu Standard skipping condition: > | org-agenda-skip-function > | List: > | List: > | Skipping range: Value Menu Skip entry > | Conditions for skipping: > | INS DEL Condition type: Value Menu TODO state is: > | todo > | Choice: Value Menu any not-done state > | INS > | INS > | [ ] Export: > | INS > `---- > > 5. Type `M-x org-agenda x'. The resulting agenda view looks like this: > > ,---- > | Headlines with TAGS match: foo > | Press `C-u r' to search again with new search string > | test-case: TODO Buckle my shoe :foo: > `---- > > I expected the TODO item to be filtered out. > > This is the value of `org-agenda-custom-commands': > > ,---- > | (("x" "Describe command here" tags "foo" > | ((org-agenda-skip-function > | '(org-agenda-skip-entry-if todo todo)))) > | ("n" "Agenda and all TODO's" > | ((agenda "" nil) > | (alltodo "" nil)) > | nil)) > `---- > > The problem seems to be that the arguments to > `org-agenda-skip-entry-if' are unquoted. The following steps verify > that. > > 6. Change `org-agenda-custom-commands', quoting the arguments to > `org-agenda-skip-entry-if'. > > ,---- > | (setq org-agenda-custom-commands > | '(("x" "Describe command here" tags "foo" > | ((org-agenda-skip-function > | '(org-agenda-skip-entry-if 'todo 'todo)))) > | ("n" "Agenda and all TODO's" > | ((agenda "" nil) > | (alltodo "" nil)) > | nil))) > `---- > > 7. Remake the custom agenda view with `M-x org-agenda x'. > > ,---- > | Headlines with TAGS match: foo > | Press `C-u r' to search again with new search string > `---- > > As expected, the TODO item is filtered. > > Best, > > Thomas > --=-=-= Content-Type: text/x-org Content-Disposition: attachment; filename=test-case.org * TODO Buckle my shoe :foo: --=-=-= Content-Type: application/emacs-lisp Content-Disposition: attachment; filename=setup.el Content-Transfer-Encoding: quoted-printable (add-to-list 'load-path "/src/org-mode/lisp") (require 'org) (setq org-agenda-files '("test-case.org")) --=-=-=--