From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Richard <theonewiththeevillook@yahoo.fr>
Subject: Re: Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode
 [8.2.7b (release_8.2.7b-6-g07d470 @
 /home/youngfrog/sourcetrees/org-mode/lisp/)]
Date: Thu, 24 Jul 2014 16:25:55 +0200
Message-ID: <87r41a6dfw.fsf@geodiff-mac3.ulb.ac.be>
References: <87fvht9tdo.fsf@yahoo.fr> <87bnsfrycn.fsf@nicolasgoaziou.fr>
	<878uni7unf.fsf@geodiff-mac3.ulb.ac.be>
	<87tx66lur9.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48516)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <theonewiththeevillook@yahoo.fr>) id 1XAJwK-0004kU-Hq
	for emacs-orgmode@gnu.org; Thu, 24 Jul 2014 10:24:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <theonewiththeevillook@yahoo.fr>) id 1XAJw9-0005J5-0D
	for emacs-orgmode@gnu.org; Thu, 24 Jul 2014 10:24:12 -0400
Received: from mxin.ulb.ac.be ([164.15.128.112]:57529)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <theonewiththeevillook@yahoo.fr>) id 1XAJw8-0005J1-Qo
	for emacs-orgmode@gnu.org; Thu, 24 Jul 2014 10:24:00 -0400
In-Reply-To: <87tx66lur9.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Thu, 24 Jul 2014 16:02:50 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Richard <theonewiththeevillook@yahoo.fr>
Cc: emacs-orgmode@gnu.org

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Nicolas Richard <theonewiththeevillook@yahoo.fr> writes:
>
>> I think it should try to have at least a sensible error message. The
>> current "Before first headline" isn't quite clear (my patch doesn't
>> address this, btw).
>
> "Not in an Org mode buffer" could be better indeed.
>
> Anyway, this kind of change (including compatibility with outline.el)
> belongs to the high-level function `org-narrow-to-subtree', not the very
> specific `org-get-limited-outline-regexp'.

Agreed.

But now that I think about it, org mode simply should avoid narrow-map
completely : users (me included) won't randomly try to run
org-narrow-to-subtree outside of org buffers (and those who do deserve a
bad error message) but they might want to give "C-x n s" a try if it is
available.

While writing a patch for changing that, I see that the code is:
(if (boundp 'narrow-map)
    (org-defkey narrow-map "s" 'org-narrow-to-subtree)
  (org-defkey org-mode-map "\C-xns" 'org-narrow-to-subtree))
(if (boundp 'narrow-map)
    (org-defkey narrow-map "b" 'org-narrow-to-block)
  (org-defkey org-mode-map "\C-xnb" 'org-narrow-to-block))
(if (boundp 'narrow-map)
    (org-defkey narrow-map "e" 'org-narrow-to-element)
  (org-defkey org-mode-map "\C-xne" 'org-narrow-to-element))

IOW, org.el purposely binds in narrow-map ! So now I don't get it :
either it's in narrow-map and should be usable widely, or it's in
org-mode-map only for org-mode files.

-- 
Nico.