From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: [RFC/PATCH] org-goto: Update for isearch changes
Date: Sun, 02 Nov 2014 17:44:36 -0500
Message-ID: <87r3xlnrxn.fsf@kyleam.com>
References: <87d295uw5g.fsf@kyleam.com> <87h9yhgrwk.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49375)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1Xl3t7-0007Ec-Mn
	for emacs-orgmode@gnu.org; Sun, 02 Nov 2014 17:44:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1Xl3t1-0005RD-KH
	for emacs-orgmode@gnu.org; Sun, 02 Nov 2014 17:44:45 -0500
Received: from mail-qa0-f53.google.com ([209.85.216.53]:61891)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1Xl3t1-0005Qr-GL
	for emacs-orgmode@gnu.org; Sun, 02 Nov 2014 17:44:39 -0500
Received: by mail-qa0-f53.google.com with SMTP id n8so7507484qaq.40
	for <emacs-orgmode@gnu.org>; Sun, 02 Nov 2014 14:44:37 -0800 (PST)
Received: from localhost (nat-130-132-173-5.central.yale.edu. [130.132.173.5])
	by mx.google.com with ESMTPSA id
	m8sm15369884qag.25.2014.11.02.14.44.36 for <emacs-orgmode@gnu.org>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Sun, 02 Nov 2014 14:44:37 -0800 (PST)
In-Reply-To: <87h9yhgrwk.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Sun, 02 Nov 2014 23:27:07 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Org-mode <emacs-orgmode@gnu.org>

Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
[...]
> C-i and C-m seem to work out the box in Emacs 24.4 anyway. Maybe the
> following is sufficient:
>
>   (when (fboundp 'isearch-other-control-char)
>     (define-key ...)
>     (define-key ...))
>
> I.e, no need to bind these keys to nil.

Hmm, I tried that (and just checked it again), but it doesn't work on my
end. C-m will exit isearch but not the indirect org-goto buffer. A
second C-m is needed to get back to the main buffer. (This is also true
for return, which is why it is also set to nil.) For C-i, it adds ^I to
the search string instead of cycling.

> Also, you should add a comment about deprecation once we drop support
> for emacs 24.3.

Will do.

--
Kyle