emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: Detect parent with SCHEDULED or DEADLINE
Date: Thu, 14 Apr 2016 09:13:08 +0200	[thread overview]
Message-ID: <87r3e8zmrf.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87vb3kx1r6.fsf@alphapapa.net> (Adam Porter's message of "Wed, 13 Apr 2016 23:17:33 -0500")

Hello,

Adam Porter <adam@alphapapa.net> writes:

> This patch seems to fix it in the current master.  Please note, I am not
> qualified to patch Org directly, so this should be reviewed by those who
> know what they're doing.  But it may at least fix it for you or be a
> starting point for fixing it.
>
>
> From 3074c8ad92a7f822374544afa9f9ada61197e4da Mon Sep 17 00:00:00 2001
> From: Adam Porter <adam@alphapapa.net>
> Date: Wed, 13 Apr 2016 22:37:43 -0500
> Subject: [PATCH] org.el: Fix getting special properties
>
> (org-entry-get-with-inheritance): If property is an special property,
> get it with org-entry-properties instead of org-property--local-values,
> which only searches drawers.
>
> This may have been broken in commit 188bae9 "Fix property inheritance with
> extended values".

Thanks for the patch.

However, `org-entry-get-with-inheritance' is not meant to be called with
special properties, which have their own inheritance rules, that cannot
be forced.

Actually, `org-entry-get-with-inheritance' is an internal function,
which shouldn't be called at all. The entry point is `org-entry-get',
which can be called with an appropriate INHERIT optional argument.

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2016-04-14  7:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 22:06 Detect parent with SCHEDULED or DEADLINE Christophe Schockaert
2016-04-14  3:04 ` Adam Porter
2016-04-14  4:17   ` Adam Porter
2016-04-14  7:13     ` Nicolas Goaziou [this message]
2016-04-14  7:24       ` Adam Porter
2016-04-14  7:57         ` Nicolas Goaziou
2016-04-14 21:28           ` Christophe Schockaert
2016-04-14 21:49             ` Christophe Schockaert
2016-04-14 22:46               ` Adam Porter
2016-04-14 23:11                 ` Christophe Schockaert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3e8zmrf.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=adam@alphapapa.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).