emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: jeeger <jeeger@mail.thenybble.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Custom timestamps in date ranges
Date: Wed, 05 Jul 2017 23:19:10 +0200	[thread overview]
Message-ID: <87r2xu60q9.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <9b107e8f40a94902df693fd65a4a376a@mail.thenybble.de> (jeeger@mail.thenybble.de's message of "Wed, 05 Jul 2017 15:52:30 +0200")

Hello,

jeeger <jeeger@mail.thenybble.de> writes:

> I have a single-line patch to contribute. In my org-mode version (Org
> mode version 9.0.9 (9.0.9-30-g796a78-elpa)), custom timestamps do not
> correctly apply to date ranges. Only the second date is replaced in
> the custom date format. I've tracked this down to org-activate-dates.
> The line
>
>       (if (match-end 3)
> 		  (org-display-custom-time (match-beginning 3) (match-end 3))
> 		  (org-display-custom-time (match-beginning 1) (match-end 1)))
>
> leads to only the second of the date range being fontified. The
> corrected version is:
>
> 	(when (match-end 3)
> 		(org-display-custom-time (match-beginning 3) (match-end 3)))
> 	(org-display-custom-time (match-beginning 1) (match-end 1))
>
> This fontifies the first date correctly as well.

Thank you.

Would it makes sense to add a comment above the `when' explaining this
is about date ranges?

Also, could you use git format-patch and add an appropriate commit
message so I can apply your changes?

Regards,

-- 
Nicolas Goaziou

     prev parent reply	other threads:[~2017-07-05 21:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 13:52 Custom timestamps in date ranges jeeger
2017-07-05 21:19 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2xu60q9.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=jeeger@mail.thenybble.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).