From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Cross Subject: Re: [feature-request] make org-quote-csv-field customizable Date: Fri, 04 Aug 2017 09:19:54 +1000 Message-ID: <87r2ws9r39.fsf@gmail.com> References: <20170802102635.GS76265@r4> <871sosl2p3.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddPPS-0005x6-Fb for emacs-orgmode@gnu.org; Thu, 03 Aug 2017 19:20:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddPPR-0003IJ-Gh for emacs-orgmode@gnu.org; Thu, 03 Aug 2017 19:20:06 -0400 Received: from mail-pf0-x22b.google.com ([2607:f8b0:400e:c00::22b]:35782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ddPPR-0003GJ-BT for emacs-orgmode@gnu.org; Thu, 03 Aug 2017 19:20:05 -0400 Received: by mail-pf0-x22b.google.com with SMTP id t86so670360pfe.2 for ; Thu, 03 Aug 2017 16:20:03 -0700 (PDT) In-reply-to: <871sosl2p3.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org, Thomas von Dein and from memory, you can also tell excel what the data type of each column in a csv file is. Nicolas Goaziou writes: > Hello, > > Thomas von Dein writes: > >> currently when exporting a table to CSV, fields are quoted automatically >> if they contain a comma or a quote character. The regexp for this >> determination is hard-coded in 'org-quote-csv-field. >> >> This is good for most use cases. However, if you want to import such a >> CSV with MS Excel then some unquoted fields will be automatically >> converted by Excel into another format. >> >> An example is a field containing 192.168.10.233. 'org-quote-csv-field >> doesn't quote it, but Excel - for reasons I cannot fathom - considers >> this a number (it doesn't do this when the last octet is below 233 >> though) and converts it to 19216810233 - which is wrong. >> >> I wrote the following code to circumvent this Excel bug: >> >> (defun tvd-org-quote-csv-field (s) >> "Quote every field and precede it with = to disable excel automatisms." >> (if (string-match "." s) >> (concat "=\"" (mapconcat 'identity >> (split-string s "\"") "\"\"") "\"") >> s)) >> >> (defun table-to-excel () >> "export current org table to CSV format suitable for MS Excel." >> (interactive) >> ;; quote everything, map temporarily 'org-quote-csv-field >> ;; to my version >> (cl-letf (((symbol-function 'org-quote-csv-field) >> #'tvd-org-quote-csv-field)) >> (org-table-export "/tmp/ex.csv" "orgtbl-to-csv"))) >> >> To make this customizable, it would be good to have a variable which >> contains the regex to determine what to quote. A parameter to >> org-table-export would be an even better solution. > > It is already possible. When asked for a format for conversion, you can > write something like: > > orgtbl-to-csv :fmt tvd-org-quote-csv-field > > > You can also define your own format: > > (defun my-orgtbl-to-Excel (table params) > "Convert the orgtbl-mode table to Excel. > This does take care of the proper quoting of fields with comma or quotes." > (orgtbl-to-generic table > (org-combine-plists '(:sep "," :fmt tvd-org-quote-csv-field) > params))) > > and use it when prompted for a format in `org-table-export'. > > Regards, -- Tim Cross