emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Sebastian Reuße" <seb@wirrsal.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix alphabetic sorting for headlines, tags
Date: Sat, 10 Feb 2018 14:02:16 +0100	[thread overview]
Message-ID: <87r2ptc813.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20180206100705.32256-1-seb@wirrsal.net> ("Sebastian Reuße"'s message of "Tue, 6 Feb 2018 11:07:05 +0100")

Hello,

Sebastian Reuße <seb@wirrsal.net> writes:

> * org.el (org-sort-entries): Use collated sorting.
> (org-tags-sort-function): Use collated sorting.
> (org-string-collate-greaterp): Add helper-function to use as defcustom
> option, since there is no ‘string-collate-greaterp’ in Emacs.

Thank you.

However, Org 9.X still supports Emacs 24, so we cannot use
`string-collate-lessp without degrading gracefully to `string-lessp' in
these Emacsen.

We could add `org-string-collate-lessp' to "org-compat.el", which would
be an alias for `string-collate-lessp' on Emacs 25+ and to
`string-lessp' otherwise.

> +(defun org-string-collate-greaterp (s1 s2 &optional locale ignore-case)
> +  "Return t if S1 is greater than S2 in collation order.

Return non-nil if...

We would also need tests for that feature.

WDYT?

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2018-02-10 13:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 10:07 [PATCH] Fix alphabetic sorting for headlines, tags Sebastian Reuße
2018-02-10 13:02 ` Nicolas Goaziou [this message]
2018-02-11 11:11   ` Sebastian Reuße
2018-02-11 16:25     ` Nicolas Goaziou
2018-02-12  8:44       ` Sebastian Reuße
2018-02-12 14:03         ` Nicolas Goaziou
2018-02-12 14:54           ` Sebastian Reuße
2018-02-12 15:47             ` Nicolas Goaziou
2018-02-12  8:46       ` Sebastian Reuße
2018-02-12 13:59         ` Nicolas Goaziou
2018-02-11 11:13   ` Sebastian Reuße
  -- strict thread matches above, loose matches on Subject: below --
2018-02-06  8:57 Sebastian Reuße

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2ptc813.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=seb@wirrsal.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).