From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Christian Moe <mail@christianmoe.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG][ODT] ODT_STYLES_FILE not read as a list
Date: Sun, 04 Nov 2018 23:05:31 +0100 [thread overview]
Message-ID: <87r2g08pn8.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <8736snjh60.fsf@christianmoe.com> (Christian Moe's message of "Tue, 30 Oct 2018 21:47:19 +0100")
Hello,
Christian Moe <mail@christianmoe.com> writes:
> It seems the ODT exporter currently fails to read the ODT_STYLES_FILE
> option as a list, as in this example from the manual
> ([[info:org#Applying custom styles]]):
>
> #+ODT_STYLES_FILE: ("/path/to/file.ott" ("styles.xml" "image/hdr.png"))
>
> This is needed if you want a complex style with e.g. an image in the
> header.
>
> Exporting this causes an "Invalid specification of styles.xml file"
> error on my recent ELPA version. The problem seems to be that the option
> is treated as a string and never tested to see if it contains a list.
>
> To reproduce the problem, place the attached documents
> odt-styles-test.org and odt-test-styles.odt in the same directory, then
> export odt-styles-test.org to ODT. The result should have a unicorn in
> the letterhead.
>
> The below quick-and-dirty patch seems to fix it, but I'm sure there's a
> better approach.
Thank you. I applied your patch with an additional check: the value should
be enclosed within round brackets.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-11-04 22:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 20:47 [BUG][ODT] ODT_STYLES_FILE not read as a list Christian Moe
2018-10-30 20:49 ` Christian Moe
2018-11-04 22:05 ` Nicolas Goaziou [this message]
2018-11-05 8:49 ` Christian Moe
2018-11-06 15:18 ` L.C. Karssen
2018-11-06 15:35 ` Christian Moe
2018-11-06 16:15 ` L.C. Karssen
2018-11-07 8:28 ` Christian Moe
2018-11-07 15:32 ` L.C. Karssen
2018-11-10 8:16 ` Nicolas Goaziou
2018-11-19 17:21 ` L.C. Karssen
2018-11-19 22:58 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2g08pn8.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=mail@christianmoe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).