From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EBHxEC66vV7NCwAA0tVLHw (envelope-from ) for ; Thu, 14 May 2020 21:37:50 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +NKWDC66vV4OTQAAbx9fmQ (envelope-from ) for ; Thu, 14 May 2020 21:37:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8AEBC940068 for ; Thu, 14 May 2020 21:37:49 +0000 (UTC) Received: from localhost ([::1]:52222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZLY4-0006kH-3U for larch@yhetil.org; Thu, 14 May 2020 17:37:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZLSv-0001wG-Ua for emacs-orgmode@gnu.org; Thu, 14 May 2020 17:32:29 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:38110) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZLSu-0005OI-Vm for emacs-orgmode@gnu.org; Thu, 14 May 2020 17:32:29 -0400 Received: by mail-wr1-x42d.google.com with SMTP id e1so683483wrt.5 for ; Thu, 14 May 2020 14:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=QnEH/PTDdcALxZ+uipx1MWFZDSkfqmz2qGePoefh74M=; b=qAzHZxZeQy/Fk5f8DNq68GTjCAEYQ90VnkUmqTUplOW4Ojm7ezU9x/ALi9PAZ0F3RM eTiW/sAhac7qshOkfqwlk/WqZTft3So+5kSyGnW0HrU6oXuO1eL/imCKjaTk6vL6RgRq i0pWMzAuyYEwL8AzBAyLd9oayVuiLWDT2qy7Jo9hHuahtvRytuEg9l6fjY7u5JQnX7iF h/UMu1hRE59Yn4Z35eE5wFEQr12yQ8NCEBaw6rCMcHLVZdRphx2t45GE4saLVfaimni7 sLDHVQbLYilGvkwXu4NFD2G1OUuoXCCSjoTXzJMv2g7m3xmhVugBb5ZeWGttzXXENRSO 7m2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=QnEH/PTDdcALxZ+uipx1MWFZDSkfqmz2qGePoefh74M=; b=kBBngC1banN7i04bcgeadn54QxLAvURH3lMitf6KErKcGnnFaxvnTZ3hKQCQ/GnkU8 Ve2eMt4utAGvkIvtk5aZwngANrhj/Aj0L3TU2uxW7NGccBvZG27yM5sr/Tb/eU60wTxg uXRKfnX1c4cid/pcWQUIbkcRsYIBlakALIc9hrYuvD1yRrlfaLsYvasssRXvvSoby0Xa 6h59P54MdXE9l6DYCbOaGDbAMzdScoh+gti/nOUR9heZhEqdguUuKmd7QXMaILl8cJJH bNFjU+6R/cpo6rzYHXwC5Avk42uJrXzXCFAj6Lb574mPCyPp+VTNlTzEPW4kKTbsI0+7 bSmg== X-Gm-Message-State: AOAM532KIGoGmlesRYUxgxF4ESvZ5O/QKwrDFSZq0zqLcod74VYzwS1P GRuP5jqabLN/SHFW1NzjTarMAXhbip+/LQ== X-Google-Smtp-Source: ABdhPJxymaUjpwjKPRN/I8UYZCPTNjOUZaYaIt6AZz4G6U7Dwy93SWyHsnRdtDvybMDOIidZKAUjtg== X-Received: by 2002:a5d:4b45:: with SMTP id w5mr486999wrs.358.1589491946648; Thu, 14 May 2020 14:32:26 -0700 (PDT) Received: from my-little-tumbleweed (200.143.13.109.rev.sfr.net. [109.13.143.200]) by smtp.gmail.com with ESMTPSA id b14sm522472wmb.18.2020.05.14.14.32.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2020 14:32:25 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: emacs-orgmode@gnu.org Subject: Re: [bug] error on RET in read-only buffer with org-return-follows-link set to t References: <87wo5egv93.fsf@no.workgroup> Date: Thu, 14 May 2020 23:32:24 +0200 In-Reply-To: <87wo5egv93.fsf@no.workgroup> (Gregor Zattler's message of "Thu, 14 May 2020 21:40:56 +0200") Message-ID: <87r1vmurrr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=kevin.legouguec@gmail.com; helo=mail-wr1-x42d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=qAzHZxZe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.21 X-TUID: bYEkR9Y1QBFF --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Gregor Zattler writes: > Dear K=C3=A9vin, org-mode developers,=20 > > with `org-return-follows-link` set to `t` in a read-only > buffer I now get a `Buffer is read-only: # notmuch-startpage.org>` error when pressing ENTER/RETURN > with point on an org-mode link. Oh, right, I added '*' to org-return's interactive spec because I was mimicking newline's; I had not considered the link-following case. Should be a simple matter of removing this '*' if I'm not mistaken: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=fix-ret-link.patch diff --git a/lisp/org.el b/lisp/org.el index be1d1c701..339418314 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -17702,7 +17702,7 @@ a timestamp or a link, call `org-open-at-point'. However, it will not happen if point is in a table or on a \"dead\" object (e.g., within a comment). In these case, you need to use `org-open-at-point' directly." - (interactive "*i\nP\np") + (interactive "i\nP\np") (let ((context (if org-return-follows-link (org-element-context) (org-element-at-point)))) (cond --=-=-= Content-Type: text/plain > I use this dozens of times a day and it would be convenient > if it was possible to resurrect the old behaviour. Right, terribly sorry for this blunder. I'll try to followup with a unit test to make sure such a regression doesn't creep in again. --=-=-=--