emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: George Sokolsky <sokolgeo@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] agenda: Consider FILETAGS for archive skipping
Date: Tue, 19 May 2020 00:43:10 +0000	[thread overview]
Message-ID: <87r1vgsqjl.fsf@kyleam.com> (raw)
In-Reply-To: <87367xmo7k.fsf@posteo.net>

George Sokolsky writes:

> I had to apply it manually on the latest org-20200518 (line numbers
> changed in this new version or me too lame) - the patch seem to fix the
> below problem and works just fine!

The patch was against the master branch (specifically 9bc0cc7fb), not
the maint branch which is the source of the ELPA archive.

> IMHO using "#+FILETAGS: ARCHIVE" is one of legitimate ways of applying
> ARCHIVE tag to items in org.

I think this statement is a reply to me saying that "I'd guess that it's
uncommon to try to set the ARCHIVE tag at the file level [because...]".
To be clear, that didn't contain a claim one way or the other about
whether "#+FILETAGS: ARCHIVE" is a legitimate way to apply an archive
tag.  But based on me taking the time to look into a code change, it
probably doesn't surprise you that my first thought was "hmph, yeah,
seems like that _should_ work".

George Sokolsky later writes:

> Kyle, could you please apply the patch to the org repository?

I sent out the patch so that others have the opportunity to provide
feedback on it as well as your initial message.  If no one does (which
is fine), at some point in the next few days I'll revisit the patch,
maybe inspect the surrounding code a bit more, and apply it (assuming I
don't end up convincing myself that it's a bad idea or needs more work).


  reply	other threads:[~2020-05-19  0:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16 10:53 Org-agenda ignores archive tag set by "#+FILETAGS: ARCHIVE" George Sokolsky
2020-05-17  5:33 ` [PATCH] agenda: Consider FILETAGS for archive skipping Kyle Meyer
2020-05-17  8:54   ` Dauer, Michael
2020-05-18  9:34   ` George Sokolsky
2020-05-18  9:52     ` Bastien
2020-05-18 10:09       ` George Sokolsky
2020-05-18 11:48         ` Bastien
2020-05-18 12:17           ` George Sokolsky
2020-05-19  0:43             ` Kyle Meyer [this message]
2020-05-21  3:05             ` Kyle Meyer
2020-05-21  7:16               ` George Sokolsky
2020-05-24 10:57 ` Org-agenda ignores archive tag set by "#+FILETAGS: ARCHIVE" Bastien
2020-05-24 17:06   ` Kyle Meyer
2020-05-25  8:28     ` George Sokolsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1vgsqjl.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=sokolgeo@posteo.net \
    --subject='Re: [PATCH] agenda: Consider FILETAGS for archive skipping' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).