From: Kyle Meyer <email@example.com> To: Ihor Radchenko <firstname.lastname@example.org> Cc: Bastien <email@example.com>, firstname.lastname@example.org, Krishan Kharagjitsing <email@example.com>, firstname.lastname@example.org Subject: Re: Cycling through TODO workflow joins the next line onto the current one Date: Mon, 28 Sep 2020 23:22:59 -0400 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <87ft78608z.fsf@localhost> Ihor Radchenko writes: >> On my emacs 27, following demonstrates the problem. > > The patch is attached. It should fix the problem. Thanks for the patch. > Subject: [PATCH] Do not remove trailing newline when deleting planning info > line. > > * lisp/org.el (org-add-planning-info): Remove front newline instead of > trailing newline when deleting planning info is completetly removed > from a heading. Fixes "Cycling through TODO workflow joins the next > line onto the current one". > > The old behaviour affected folded headlines containing only planning > info in the body: > > Before deletion: > * DONE Headline<begin fold> > CLOSED: [2020-09-23 Wed 21:39]<end fold> > * test > > After deletion: > * DONE Headline<begin fold> > <end fold>* test > > The newline after the first headline is hidden making both the > headlines appear at the same visual line. > > New behaviour: > After deletion: > * DONE Headline > * test > > All the folded text is completely removed. Nicely explained, and appears to work well. Applied (5d4c0f59d) with a couple of minor tweaks to the commit message: 1: 8e776cca1 ! 1: 5d4c0f59d Do not remove trailing newline when deleting planning info line. @@ Metadata Author: Ihor Radchenko <firstname.lastname@example.org> ## Commit message ## - Do not remove trailing newline when deleting planning info line. + Do not remove trailing newline when deleting planning info line * lisp/org.el (org-add-planning-info): Remove front newline instead of - trailing newline when deleting planning info is completetly removed - from a heading. Fixes "Cycling through TODO workflow joins the next - line onto the current one". + trailing newline when planning info is completetly removed from a + heading. The old behaviour affected folded headlines containing only planning info in the body: @@ Commit message All the folded text is completely removed. + Reported-by: Krishan Kharagjitsing <email@example.com> + Ref: https://orgmode.org/list/CAKXDJO2xUgBoTx-XcL7WbXyvP2Oj8iVEmdmRNCVzdRTEwzNR+Q@mail.gmail.com + ## lisp/org.el ## @@ lisp/org.el: (defun org-add-planning-info (what &optional time &rest remove) ;; If there is nothing more to add and no more keyword is
prev parent reply other threads:[~2020-09-29 3:23 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-20 6:37 Krishan Kharagjitsing 2020-09-20 11:56 ` Nicholas Savage 2020-09-23 7:17 ` Bastien 2020-09-23 13:28 ` Richard Kim 2020-09-23 13:48 ` Richard Kim 2020-09-23 14:22 ` Ihor Radchenko 2020-09-23 23:49 ` Samuel Wales 2020-09-29 3:22 ` Kyle Meyer [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: Cycling through TODO workflow joins the next line onto the current one' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).