From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +DPcJP+rfWCVwQAAgWs5BA (envelope-from ) for ; Mon, 19 Apr 2021 18:12:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6MmWIP+rfWBydwAA1q6Kng (envelope-from ) for ; Mon, 19 Apr 2021 16:12:47 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2B35636AE6 for ; Mon, 19 Apr 2021 18:12:47 +0200 (CEST) Received: from localhost ([::1]:47228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYWVy-0001Lz-8l for larch@yhetil.org; Mon, 19 Apr 2021 12:12:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYWRl-0005Rz-1W for emacs-orgmode@gnu.org; Mon, 19 Apr 2021 12:08:25 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:57381) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYWRi-00025A-9q for emacs-orgmode@gnu.org; Mon, 19 Apr 2021 12:08:24 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 0FD811BF20B; Mon, 19 Apr 2021 16:08:17 +0000 (UTC) From: Nicolas Goaziou To: Maxim Nikulin Subject: Re: [Patch] to correctly sort the items with emphasis marks in a list References: <87a6qg1rjx.fsf@posteo.net> <874kgft7n1.fsf@nicolasgoaziou.fr> <87blanxb1z.fsf@posteo.net> <87lf9fa3ak.fsf@posteo.net> <87sg3n8f33.fsf@posteo.net> <87tuo2d670.fsf@nicolasgoaziou.fr> Mail-Followup-To: Maxim Nikulin , emacs-orgmode@gnu.org Date: Mon, 19 Apr 2021 18:08:17 +0200 In-Reply-To: (Maxim Nikulin's message of "Mon, 19 Apr 2021 19:34:42 +0700") Message-ID: <87r1j6b6ku.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.201; envelope-from=mail@nicolasgoaziou.fr; helo=relay8-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618848767; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=v49rYLc1oV+XQrN1dO1ONgR8H2NtgouHEZoC5mYsKBQ=; b=C7w3KROIuyXhp3YjyiSlqQ7J3gXUNNsAWND3B0Osrtsm4bDDio+oIzGiO/bBjAqHAgpOpF PY5YoxG1WaLtmu0A2lciU/NsdbdivzNDE9Xm14zaz3MbyVvexOlmf55YS5ptqHuzqG5tbL Rd9ZV6dywHA2Q7VqSabKhEchMTXzlR4DsvMKFinBrKhWlFU5PzZeQW9W2K+kKF0ULgov3o i9pTqXYET4vlQtzppYdF2Pto4+noaHzr04AVvZX+x3pGIActOfxZwdPJW0pyhAfbfRtlmy jZpeKXS5c9dCXYRPKLF5zdWSkxftSmwdbtLbkjz+32E4FbjKwmWXJIKv0q8oMA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618848767; a=rsa-sha256; cv=none; b=LdBGYAxDWXflP1/6b2QSDzQcr4wmC9nAOrOM5pm0rPHynvf/vnQ4riQzKQ44W8AWhQ0e8v wuRMid6e/JbrD5yuk32lx1iplstTajMwViLtg8xdO//65mWgs5BG53vEHX864u991ZC18k rVg+hxQq0K3seVI805/cXW4TvvaThfEFxZqsQQiMvs+BKnJ6tUFMSiRrxCUGlWeubAo03J 2crDw8e8qBP18uMjg+tC71VNRMxQDhwCz9XppUDvvaEFJ5opKUvKY2/uIVvIlgl97Kjee4 H33zWcr5uD6JzNecZ2QoxI/I1g59tKKBQLHfjHHtjgzH1i13efuWUwqMrASzFA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.44 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 2B35636AE6 X-Spam-Score: -2.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: zBv5tk01CyIs Hello, Maxim Nikulin writes: > Just a curiosity, what is style guide recommendation: let - lambda or > cl-labels? I stay away from CL as much as possible, otherwise newcomers will have to learn two languages to start contributing, Elisp and CL (cl-loop, ewww). CL is still necessary however, as we cannot use `seq' yet. Also, there is `letrec' instead of `cl-labels'. > In my opinion, a more severe limitation comes from sequential > regexp-based approach. Consider stripping markers from > 1. "a =b *c* d= e" > 2. "*b* /i/" Fair enough. Here comes another, more involved, attempt. --8<---------------cut here---------------start------------->8--- (defun org-sort-remove-invisible (s) "Remove emphasis markers and any invisible property from string S. Assume S may contain only objects." ;; org-element-interpret-data clears any text property, including ;; invisible part. (org-element-interpret-data (let ((tree (org-element-parse-secondary-string s (org-element-restriction 'paragraph)))) (org-element-map tree '(bold code italic strike-through underline verbatim) (lambda (o) (pcase (org-element-type o) ;; Terminal object. Replace it with its value. ((or `code `verbatim) (let ((new (org-element-property :value o))) (org-element-insert-before new o) (org-element-put-property new :post-blank (org-element-property :post-blank o)))) ;; Non-terminal objects. Splice contents. (_ (let ((contents (org-element-contents o)) (c nil)) (while contents (setq c (pop contents)) (org-element-insert-before c o)) (org-element-put-property c :post-blank (org-element-property :post-blank o))))) (org-element-extract-element o))) ;; Return modified tree. tree))) --8<---------------cut here---------------end--------------->8--- It is not perfect, but it does a better job. WDYT? > + ;; Space role in sorting. > + ;; Test would fail for locales with ignored space, e.g. en_US, it works > + ;; in C and currently rare locales having significant space (es_ES, pl_PL) > + (should > + (equal "- Time stamp\n- Timer\n" > + (org-test-with-temp-text "- Timer\n- Time stamp\n" > + (org-sort-list t ?a) > + (buffer-string)))))) Since this test is bound to fail for some developers, I assume it shouldn't be included. > + (dolist (case '(("Lost =in *verbatim* text= fragment" . > + "Lost in *verbatim* text fragment") > + ("Adjucent emphasis: *Overlapped* /regexps/" . > + "Adjucent emphasis: Ovelapped regexps"))) ^^^^ typo Regards, -- Nicolas Goaziou