emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Timothy <tecosaur@gmail.com>
Cc: emacs-orgmode@gnu.org, "Marvin J." <silbersplitter@googlemail.com>
Subject: [PATCH] Re: Bug: `org-fill-paragraph' relies on M-q being bound to `fill-paragraph' [9.4.6 (9.4.6-12-gdcc3a8-elpa @ /home/mwj/.emacs.d/elpa/org-20210809/)]
Date: Wed, 01 Sep 2021 21:00:33 +0800	[thread overview]
Message-ID: <87r1e8xxfy.fsf@localhost> (raw)
In-Reply-To: <87o89doi2m.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

Timothy <tecosaur@gmail.com> writes:

> With regards to triggering M-q in the edit buffer,
> considering that different modes can have different fill commands, might
> you have any suggestions on what command this could be replaced by?

I think simply calling `fill-paragraph' (bound to "M-q" by default)
should do. From it's docstring, it should take care about mode-specific
fill functions:

>> If fill-paragraph-function is non-nil, we call it (passing our
>> argument to it), and if it returns non-nil, we simply return its value.

Also, the docstring says that fill-paragraph-function is expected to
return non-nil when the filling is done there. For some reason, it is
not done in org-fill-paragraph.

The attached is patch solving the "M-q" problem and making sure the
org-fill-paragraph returns non-nil.

Beware that I am not very familiar with fill.el. It would be great if
someone more knowledgeable take a look at the patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Do-not-rely-on-M-q-binding-for-filling-src-block.patch --]
[-- Type: text/x-diff, Size: 1713 bytes --]

From 2ff317ece235890da5e1f8246dba08d585b0fbaa Mon Sep 17 00:00:00 2001
Message-Id: <2ff317ece235890da5e1f8246dba08d585b0fbaa.1630500712.git.yantar92@gmail.com>
From: Ihor Radchenko <yantar92@gmail.com>
Date: Wed, 1 Sep 2021 20:42:05 +0800
Subject: [PATCH] Do not rely on M-q binding for filling src-block

* lisp/org.el (org-fill-element): Use `fill-paragraph' instead of
simulating "M-q" binding.
(org-fill-paragraph): Return t as described in `fill-paragraph'

Fixes https://orgmode.org/list/CAH7LOt0PO3js6_+Cbinm6EYNx0KFvpfiSS7Dwc1EXsfHfHkHVA@mail.gmail.com/
 lisp/org.el | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index ce68f4692..601526e84 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -19486,7 +19486,9 @@ (defun org-fill-element (&optional justify)
       ;; the buffer.  In that case, ignore filling.
       (cl-case (org-element-type element)
 	;; Use major mode filling function is source blocks.
-	(src-block (org-babel-do-key-sequence-in-edit-buffer (kbd "M-q")))
+	(src-block (org-babel-do-in-edit-buffer
+                    (mark-whole-buffer)
+                    (funcall-interactively #'fill-paragraph justify 'region)))
 	;; Align Org tables, leave table.el tables as-is.
 	(table-row (org-table-align) t)
@@ -19621,7 +19623,9 @@ (defun org-fill-paragraph (&optional justify region)
     ;; previously unmodified), then flip the modification status back
     ;; to "unchanged".
     (when (and hash (equal hash (org-buffer-hash)))
-      (set-buffer-modified-p nil))))
+      (set-buffer-modified-p nil))
+    ;; Return non-nil.
+    t))
 (defun org-auto-fill-function ()
   "Auto-fill function."

  reply	other threads:[~2021-09-01 13:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-14 10:31 Bug: `org-fill-paragraph' relies on M-q being bound to `fill-paragraph' [9.4.6 (9.4.6-12-gdcc3a8-elpa @ /home/mwj/.emacs.d/elpa/org-20210809/)] Marvin J.
2021-08-15 20:18 ` Tim Cross
2021-08-31 13:30 ` Timothy
2021-09-01 13:00   ` Ihor Radchenko [this message]
2021-09-26  7:05     ` [PATCH] " Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1e8xxfy.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=silbersplitter@googlemail.com \
    --cc=tecosaur@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).