From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eEptB8OqqmFEcQAAgWs5BA (envelope-from ) for ; Sat, 04 Dec 2021 00:39:47 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cP0bA8OqqmGAHAAAB5/wlQ (envelope-from ) for ; Fri, 03 Dec 2021 23:39:47 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5776429CCC for ; Sat, 4 Dec 2021 00:39:46 +0100 (CET) Received: from localhost ([::1]:59246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtI9Z-0005Cl-GO for larch@yhetil.org; Fri, 03 Dec 2021 18:39:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtI82-00059F-6L for emacs-orgmode@gnu.org; Fri, 03 Dec 2021 18:38:10 -0500 Received: from [2607:f8b0:4864:20::102c] (port=38613 helo=mail-pj1-x102c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtI80-0002Qw-Fd for emacs-orgmode@gnu.org; Fri, 03 Dec 2021 18:38:09 -0500 Received: by mail-pj1-x102c.google.com with SMTP id p18-20020a17090ad31200b001a78bb52876so6333491pju.3 for ; Fri, 03 Dec 2021 15:38:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:subject:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=NHlL4wWWGqmY1GI2qaDIwXoQva9+P4UkGn/U2SAxvRs=; b=L+sB5bt0TA5d59a0TYy4JOABKRM3RbhpV2EgsUeYmFdL8kcfCprGXYp6F/zR5KKGPl KMvfGdYqs68fESgiF5sSscz7CAao5FiB7Zd4QTkWf35P70nvZcyJTy+Hvo8ePLkookFS nqbpjEzKKED3HrPWWXU+j+VvmEltq4nZMXtq2CHhoAGMxlSI9Nr71LeZCGNQK173xt/+ jx5h908+6Jf7YxrFA53vDsrPrrBj9ZjTE1r7UsbKLIyLmFw0j+jzqE8tkMWdF/UvgtHf pLkG9YL3ADfk0gBJGWFFzjQ1/yCJixQLqcump+N8WeSNNoZIFJMgsJDJmv3jvYC2sGKx f5Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=NHlL4wWWGqmY1GI2qaDIwXoQva9+P4UkGn/U2SAxvRs=; b=Lpk5fDYnE8Dof1WytGG4EeLDptM9/hcVxiRXCfZYFQfyFw02l9Oh8kZMtv3ffjppDI bEbPx9y8LuYgb2NiHq/N4G1qvFPBPxAPqsv08/jO3V5unfXeRjspUk0iD5YijuGkboYi 8eSGptYO+fLRRF+gI7Bn7rSD80u1uQvAbK62Ujc8/LXSJdw/FoOekBAXgkyoNhN7NE2b 3RHAedZZa/7qmhgNufELMDplTouaRLRrMacojvF1HnGlD5wDwQqWckFixb8jrJSlLeTY y+EBgHIn+vTbn0VXvM9Zi/5Imw7tz3EJ4/Ne68NKTVLHR/Kxm8TCtDyAvfadfW+cNMw6 /Hig== X-Gm-Message-State: AOAM533NHF2x0f6n9Xtw3LOoo3cSmcsYMa4C4TfQ95RA4gL6tLFSdHG3 BdrCx1/hVHQYKDgLuRL7iSQt2f8kAcA= X-Google-Smtp-Source: ABdhPJz+/moA4ITGnD4DAbIBPZ2zajF8LqR6CcqSj5E2JrT5LdMVgOGawXdUgJyjnXf8utwytQja+w== X-Received: by 2002:a17:90b:3e81:: with SMTP id rj1mr17937270pjb.111.1638574686918; Fri, 03 Dec 2021 15:38:06 -0800 (PST) Received: from dingbat (2001-44b8-31f2-bb00-ae68-ae3c-97fa-f661.static.ipv6.internode.on.net. [2001:44b8:31f2:bb00:ae68:ae3c:97fa:f661]) by smtp.gmail.com with ESMTPSA id ls14sm7055500pjb.49.2021.12.03.15.38.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Dec 2021 15:38:06 -0800 (PST) References: <5a675071-292a-1f10-9791-5085a6d8bef8@posteo.eu> User-agent: mu4e 1.7.5; emacs 28.0.60 From: Tim Cross To: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-src.el: add option `org-src-native-defun-movements' Date: Sat, 04 Dec 2021 10:27:43 +1100 In-reply-to: <5a675071-292a-1f10-9791-5085a6d8bef8@posteo.eu> Message-ID: <87r1atgsyt.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102c (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=theophilusx@gmail.com; helo=mail-pj1-x102c.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638574786; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=NHlL4wWWGqmY1GI2qaDIwXoQva9+P4UkGn/U2SAxvRs=; b=FVlUwyn08z2J+UzasIDsNl+UzujlnKS/EAlhBgeV3kuNTgjrXRrLG/qeUjZZh0jBzqdnaE EtTWGusnBrzRqq1tgNJHsfAJiIPKFca9wpwd61szD4ghDrSlb+YoCU5Lgr7MFT2M4XrGtf OquEs1JqD1jkuXpdxUJdfjuOzbI/Ylpk2Z3p1of77MDvy4sjU/TW0crtR4XA55HXX59e7j vGubYleU0qv8z0AmG/a3xaLZZrBH3z72a4rERm5s7YgPNPMBO6HlddIEfmJ7Hp12UzNxmY hSBVPm6RTDtjF2H7ahIbZ2z4WPbGSOj9RIC0lvNmjJpSVBIy8dg5be0/wOYv3g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638574786; a=rsa-sha256; cv=none; b=X18s5OiNTwc14RPDWWS/Y8mEr83BO3WuZFFCf50t13PBeEBY2+g6tgke9Wrs06Rx/MVHqI qKDozFHDyT5Oz+Z+Bo/IAb+QWxfDVyKazYdRPNBCck/CgAzPIRkLMHPAE6VjH5Oj/eQIM/ W96AFwAHjiVrCtceidYAKEyKIroR5EJ1PJRg1jDN6L8BgCujIa0CkOSIPtZNivWXznr1Oh l1u3gLZvgkczjCHlwUJhsb/pISEwvvr2tQ0+Z4NCHPRoSDw5Ca8hLA//hhr2WHAeqkUKZ3 ZIWWErEq59o6Sw7U7FVM+9CQ0ZwOJH8SmaCvzBudDWSq2G5zmqr2DHQ0ISxuIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=L+sB5bt0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.13 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=L+sB5bt0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5776429CCC X-Spam-Score: -4.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: dttkdXZThFvT S=C3=A9bastien Miquel writes: > Hi, > > The attached patch adds a new option ~org-src-native-defun-movements~ > that makes ~beginning-of-defun~, ~end-of-defun~ and ~eval-defun~ work > natively when called from inside an org src block : those functions > are called from an org src edit buffer, in the appropriate language > mode. Without this patch, calling =3Deval-defun=3D on elisp code fails. > > With this option set to t by default, this is a breaking change. To > get to the beginning/end of a src block you'd have to call > ~org-backward-element~ or ~org-forward-element~ directly, instead of > ~beginning-of-defun~. Or you could disable the new behaviour by > setting ~org-src-native-defun-movements~ to nil. > As this is a breaking change, it should not be on by default. This also seems like an edge case and I'm not convinced yet another option is justified. Why have eilisp in org blocks rather than an emacs-lisp block?