From: Ihor Radchenko <yantar92@gmail.com>
To: Ignacio Casso <ignaciocasso@hotmail.com>,
Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: tom@tomdavey.com, emacs-orgmode@gnu.org
Subject: Timestamp parsing inside node properties and other contexts out of org-element-object-restrictions (was: [BUG] Agenda no longer works for timestamps inside properties drawer [9.5.2 (release_9.5.2-24-g668205 @ /home/ignacio/repos/emacs/lisp/org/)])
Date: Tue, 22 Mar 2022 18:00:00 +0800 [thread overview]
Message-ID: <87r16umhnj.fsf@localhost> (raw)
In-Reply-To: <87tubqmi94.fsf@localhost>
Ihor Radchenko <yantar92@gmail.com> writes:
> After further reading the source code, I figured that agenda is, in
> fact, supposed to handle timestamps inside property drawers. Optional
> arguments for org-at-timestamp-p imply that, in agenda specifically,
> timestamps inside node properties are considered timestamps despite they
> are not being parsed as timestamps by org-element.
Even though I fixed the reported issue with agenda not showing headings
with matching timestamps inside property drawers, this situation is
revealing a big inconsistency in Org mode's handling of timestamps.
org-at-timestamp-p usage implies that Org syntax for timestamps is not
only context-dependent, but also depends on current command!
org-at-timestamp-p is called with non-nil argument in a number of
functions in Org:
- org-clock-timestamps-change
- org-mouse-delete-timestamp
- org-mouse-context-menu
- org-follow-timestamp-link
- org-get-repeat
- org-auto-repeat-maybe
- org-time-stamp
- ... many more in org.el
So, depending on the current command, Org may on may not treat objects
matching org-ts-regexp-both as timestamps.
This situation complicates syntax and makes org-element unreliable when
dealing with Org buffers.
Should we just simply allow timestamps to be a part of node property
values? Should we _not_ treat timestamp-looking text outside their
allowed contexts (like quotes, source blocks, etc) as timestamps?
Best,
Ihor
next prev parent reply other threads:[~2022-03-22 10:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 10:06 [BUG] Agenda no longer works for timestamps inside properties drawer [9.5.2 (release_9.5.2-24-g668205 @ /home/ignacio/repos/emacs/lisp/org/)] Ignacio Casso
2022-03-12 12:28 ` Ihor Radchenko
2022-03-21 15:58 ` Tom Davey
2022-03-21 23:21 ` Ignacio Casso
2022-03-22 0:50 ` Samuel Wales
2022-03-22 10:02 ` Ihor Radchenko
2022-03-22 10:17 ` Ihor Radchenko
2022-03-22 21:02 ` Tim Cross
2022-03-23 12:07 ` Ihor Radchenko
2022-03-23 0:10 ` Samuel Wales
2022-03-23 12:21 ` Ihor Radchenko
2022-03-24 3:38 ` Samuel Wales
2022-03-22 3:43 ` Tom Davey
2022-03-22 9:47 ` Ihor Radchenko
2022-03-22 10:00 ` Ihor Radchenko [this message]
2022-03-22 21:10 ` Timestamp parsing inside node properties and other contexts out of org-element-object-restrictions (was: [BUG] Agenda no longer works for timestamps inside properties drawer [9.5.2 (release_9.5.2-24-g668205 @ /home/ignacio/repos/emacs/lisp/org/)]) Tim Cross
2022-03-22 23:16 ` Tom Davey
2022-03-23 0:25 ` Tim Cross
2022-03-23 13:13 ` Ihor Radchenko
2022-03-22 23:05 ` Timestamp parsing inside node properties and other contexts out of org-element-object-restrictions Nicolas Goaziou
2022-03-23 13:06 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r16umhnj.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=ignaciocasso@hotmail.com \
--cc=mail@nicolasgoaziou.fr \
--cc=tom@tomdavey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).