From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eB87FO4FaWKrDAAAbAwnHQ (envelope-from ) for ; Wed, 27 Apr 2022 10:59:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id OBBiFO4FaWLRNAAA9RJhRA (envelope-from ) for ; Wed, 27 Apr 2022 10:59:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D8C933ADD3 for ; Wed, 27 Apr 2022 10:59:25 +0200 (CEST) Received: from localhost ([::1]:40156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njdW8-00044i-Ui for larch@yhetil.org; Wed, 27 Apr 2022 04:59:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njdGU-00059d-7f for emacs-orgmode@gnu.org; Wed, 27 Apr 2022 04:43:14 -0400 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:45013) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njdGS-0007MT-94 for emacs-orgmode@gnu.org; Wed, 27 Apr 2022 04:43:13 -0400 Received: by mail-pj1-x1036.google.com with SMTP id m14-20020a17090a34ce00b001d5fe250e23so1189553pjf.3 for ; Wed, 27 Apr 2022 01:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=VhlFDGvTYMFZE9VtH5Ya+5xGb8V8bVD342u7Cw0BUQ4=; b=SY1jtnWzGc3k0PsYSDiLwkLf4mlMSTGKJ3eBU53UDrK/grDm7KGG4PrxRSsGytiA4i rLv0FiPrZ9jsGKeowQOkO2sdbix39+qV51FOn7E2mE3UJdi8GW0TkjkXWAZ0ngP8dlYI e+zjyX2lAeikst8s3rzyNsK9zbrHBdbBZEvu6BcxUuCCKYMRtAUb/iXZSbAsYzCcsWYz 0AJEvjrlv+DHiuq4CDLFQor2tIXGUw/r4uD4qmLWix8WEr5GYzl7AshuHNXv8LpzqrC0 iqbcHxUmrlLHzHkApYfN+qK/i2x9hStI4pXaJ3dD9VyWLJxsOaXg7iOl0ANxJD2FPi7a HObA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=VhlFDGvTYMFZE9VtH5Ya+5xGb8V8bVD342u7Cw0BUQ4=; b=vMGf9W6T07c3qAJMwio2TnXjYHFcF7gTeNzeZ34JGUFXiIEbCewlRtamzEDTlaR6J/ rZXRwWK5ECqqKeXoyhHcIlLtg0APMtV6tKL0K6A8U5fw1GA3K7qJ+obhTiJCRP8RhhwP 0jORsrPvjPBik4IAEsZEw5Yg/20t+6KAtMWuPbGkV7sU6oSz2+H8Qe9I6TUUK+Ox27Df XUHGM/rLfoJr3F2ZHUnftFDGM+sZQc2zZZFyOV9BauX96qqXEaH82Orr6WBcPBsXm0km dHCKYJpPYs7opK8gw9wqTO6NavG5FWy164HBD3LGq4WwXo6BokpTA3ScfR/8jL5BRjW5 SjCg== X-Gm-Message-State: AOAM530UgQB0qlvBRLIE/SrNKIocDHS/cVzPNDyiG2SYa7XzPetBSAVP hC2CvR1uA/8BYBuvgktGsaE= X-Google-Smtp-Source: ABdhPJyL23QYKAWEo16EpZz8zz51gIShVCQfhBjEAlzkHFRK40AVEGyB5iUFLIQfUVH3w8uySrgg/A== X-Received: by 2002:a17:902:9a8c:b0:15a:a21:b52a with SMTP id w12-20020a1709029a8c00b0015a0a21b52amr27498451plp.86.1651048990696; Wed, 27 Apr 2022 01:43:10 -0700 (PDT) Received: from localhost ([23.27.206.157]) by smtp.gmail.com with ESMTPSA id u9-20020a17090a1f0900b001bf31f7520csm1889035pja.1.2022.04.27.01.43.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 01:43:09 -0700 (PDT) From: Ihor Radchenko To: 3462869.oopU1TnKvU@felipe-thinkpad-x200 Subject: Re: [PATCH] update ob-scheme to latest changes in geiser package In-Reply-To: <874k2k0vtw.fsf@terra.tmtvl.info> References: <878rrw0w3x.fsf@terra.tmtvl.info> <874k2k0vtw.fsf@terra.tmtvl.info> Date: Wed, 27 Apr 2022 16:44:00 +0800 Message-ID: <87r15ivru7.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=yantar92@gmail.com; helo=mail-pj1-x1036.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, TO_MALFORMED=0.1, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Lema , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651049965; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VhlFDGvTYMFZE9VtH5Ya+5xGb8V8bVD342u7Cw0BUQ4=; b=gSIxZbcZrFGcBoLb53bSwslfDNwhlzCTcGZdcynzNK+LtmzFFfhI21u1doHYSVdbpXUx4e 5lEAPNkza+Iedg/oJluWWx1Qtv9Vu5ImRHHR2O18qRcKzzk7l6lpY733fq5em/dw3L6HYH XAgZqzmg+MxWPFiq4E6ioRyt9xxAX22JArP8xHJkJ8bKpH3mrM6H1ZJo/UlzCucVgs4X/d 9aUbeBAMvkjMcUjdYYZ67DRwOMaTjpz0pTGxVQROTtNS2mHnmFenv0Jh8s+H2RcOZHqrgT Xsi+Fu25218EF6//f3Wf0h+u42uaw628cMuYguFhD1nyqT1xhGhaHRL4KAdsxw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651049965; a=rsa-sha256; cv=none; b=uaH+657p0G3o1yDGW4JF2Ik3q0dd46nSO9HzJIHYCjkSpP3ULObwydTwMp5vePVoYwXnWx P1DjGnVuC4TS/FgcoeTAWr4mKcfuV7AXU2FsK5VuaQWre6i/GSYT0EzfsWQKn70hLg3wzt vtcKugi4N7R/PrTOUHeShd1FEktU9pKD9cmapHUWt2xfCEoVZ3hrRtM+0g28gWBl2UmQTN kloHI2aErKvlAbih2/bwQdZDQdd2hVKXghET1/3NhWybeUV1s+FqQdCr7KspxwmQZGrQJJ HucoRrst3WUdkk5zmbQyK7cx4RQmer55lc8FEguk8vE3+BHvq9hu+H05sUTkig== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=SY1jtnWz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=SY1jtnWz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D8C933ADD3 X-Spam-Score: -5.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: +aDuumsIszlL Tim Van den Langenbergh writes: > I have taken the liberty of reformatting the patch you created for ob-scheme. > You can find it enclosed. Thanks! Since Felipe has no objections, your patch should be good to apply. > If it is fine with you and the org-mode maintainers it can be applied as-is, > particularly since it is a tiny change. > I have also added some additional information to the commit message, such as > when the `geiser-eval-region/wait' function was introduced. Could you kindly add the geiser version info as a comment inside code? Commit message is an unlikely place to be checked regularly and be noticed as geiser is updated in future. Comments are generally preferred over commit messages: https://orgmode.org/worg/org-contribute.html#commit-messages -> -> https://git.savannah.gnu.org/cgit/emacs.git/plain/CONTRIBUTE >> - Explaining the rationale for a design choice is best done in comments >> in the source code. However, sometimes it is useful to describe just >> the rationale for a change; that can be done in the commit message >> between the summary line and the file entries. Best, Ihor