emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ihor Radchenko <yantar92@gmail.com>
To: 3462869.oopU1TnKvU@felipe-thinkpad-x200
Cc: Felipe Lema <felipelema@mortemale.org>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] update ob-scheme to latest changes in geiser package
Date: Wed, 27 Apr 2022 16:44:00 +0800	[thread overview]
Message-ID: <87r15ivru7.fsf@localhost> (raw)
In-Reply-To: <874k2k0vtw.fsf@terra.tmtvl.info>

Tim Van den Langenbergh <tmt_vdl@gmx.com> writes:

> I have taken the liberty of reformatting the patch you created for ob-scheme.
> You can find it enclosed.

Thanks! Since Felipe has no objections, your patch should be good to apply.

> If it is fine with you and the org-mode maintainers it can be applied as-is,
> particularly since it is a tiny change.
> I have also added some additional information to the commit message, such as
> when the `geiser-eval-region/wait' function was introduced.

Could you kindly add the geiser version info as a comment inside code?
Commit message is an unlikely place to be checked regularly and be
noticed as geiser is updated in future.

Comments are generally preferred over commit messages:

https://orgmode.org/worg/org-contribute.html#commit-messages ->
-> https://git.savannah.gnu.org/cgit/emacs.git/plain/CONTRIBUTE
>> - Explaining the rationale for a design choice is best done in comments
>>   in the source code.  However, sometimes it is useful to describe just
>>   the rationale for a change; that can be done in the commit message
>>   between the summary line and the file entries.

Best,
Ihor

next prev parent reply	other threads:[~2022-04-27  8:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <878rrw0w3x.fsf@terra.tmtvl.info>
2022-04-23 13:29 ` [PATCH] update ob-scheme to latest changes in geiser package Tim Van den Langenbergh
2022-04-26 15:04   ` Felipe Lema
2022-04-27  8:44   ` Ihor Radchenko [this message]
2022-05-07 12:04     ` Tim Van den Langenbergh
2022-05-08 10:02       ` Ihor Radchenko
2021-12-29 18:03 Felipe Lema
2021-12-30  1:53 ` Felipe Lema
2021-12-30 15:50   ` Max Nikulin
2021-12-30 19:01   ` Felipe Lema
2021-12-31  4:22     ` Max Nikulin
2022-02-06  9:50       ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r15ivru7.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=3462869.oopU1TnKvU@felipe-thinkpad-x200 \
    --cc=emacs-orgmode@gnu.org \
    --cc=felipelema@mortemale.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).