From: Ihor Radchenko <yantar92@gmail.com>
To: Phil Hudson <phil.hudson@iname.com>
Cc: emacs orgmode-mailinglist <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Re: [BUG] org-element-map doco should refer to org-element-parse-buffer [9.5.2 (9.5.2-gfbff08 @ /home/phil/.emacs.d/elpa/org-9.5.2/)]
Date: Sat, 14 May 2022 13:09:05 +0800 [thread overview]
Message-ID: <87r14wbszy.fsf@localhost> (raw)
In-Reply-To: <CAJ1MqVEr8+gdPciETc2tGCgigGjpTAj7gZx9PhTbXZZ8n+_gpg@mail.gmail.com>
Phil Hudson <phil.hudson@iname.com> writes:
> Thanks Ihor, that's great!
>
> One tiny nit-pick: I think "e.g." is deprecated in favor of the
> explicit literal "for example". My source for this is (info "(elisp)
> Documentation Tips").
Fair point, though searching across org-element.el reveals that e.g. is
used in many places. I do not see it as too much of a big deal. Will
just update the patch here.
> Also, just spotted what I think is a pre-existing typo, "objects
> types", which I think should probably be just "object types". Might as
> well fix that while we're at it.
Fixed.
Applied the new version of the patch onto main as 3996ea99a.
Best,
Ihor
next prev parent reply other threads:[~2022-05-14 5:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 6:12 [BUG] org-element-map doco should refer to org-element-parse-buffer [9.5.2 (9.5.2-gfbff08 @ /home/phil/.emacs.d/elpa/org-9.5.2/)] Phil Hudson
2022-05-03 3:44 ` [PATCH] " Ihor Radchenko
2022-05-03 8:10 ` Phil Hudson
2022-05-14 5:09 ` Ihor Radchenko [this message]
2022-05-14 8:01 ` Phil Hudson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r14wbszy.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=phil.hudson@iname.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).