From: Ihor Radchenko <yantar92@gmail.com>
To: Timothy <orgmode@tec.tecosaur.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Babel evaluation: location and timing information
Date: Tue, 20 Sep 2022 16:29:48 +0800 [thread overview]
Message-ID: <87r106qwhv.fsf@localhost> (raw)
In-Reply-To: <87edw9z81n.fsf@tec.tecosaur.net>
Timothy <orgmode@tec.tecosaur.net> writes:
> - (message "executing %s code block%s..."
> + (message "executing %s %s %s..."
> (capitalize lang)
> + (pcase (org-element-type (org-element-at-point))
> + ('src-block "code block")
> + ('babel-call "call")
> + ('paragraph "inline code block"))
This will not work, for example, when inline src block is located inside
a headline. One can think of various other non-paragraph scenarios as well.
Also, even though org-element-at-point should be caching recent calls,
I'd try to test the performance before/after the patch on large number
of src blocks (like in your config). org-element-at-point can add a fair
bit of CPU load in some scenarios where we have fallback to the full
O(Log N) AVL-tree lookup.
> + (let ((time-info
> + (if (and exec-time (> (float-time exec-time) 0.05))
> + (format " (took %.1fs)" (float-time exec-time))
Why 0.05??
--
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92
next prev parent reply other threads:[~2022-09-20 8:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 3:09 [PATCH] Babel evaluation: location and timing information Timothy
2022-09-19 12:28 ` Fraga, Eric
2022-09-19 14:52 ` Max Nikulin
2022-09-22 7:03 ` Timothy
2022-09-22 12:15 ` Max Nikulin
2022-09-23 2:22 ` Ihor Radchenko
2022-09-23 16:21 ` line-number-at-pos performance and cache-long-scans Max Nikulin
2022-09-20 8:29 ` Ihor Radchenko [this message]
2022-09-22 7:05 ` [PATCH] Babel evaluation: location and timing information Timothy
2022-09-23 2:27 ` Ihor Radchenko
2022-09-23 16:46 ` [PATCH] Babel evaluation: location and timing information (v2) Timothy
2022-09-24 3:11 ` Ihor Radchenko
2022-09-24 9:12 ` Timothy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r106qwhv.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=orgmode@tec.tecosaur.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).