emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ihor Radchenko <yantar92@posteo.net>
To: necaris@gmail.com
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Send table rows to OCaml as tuples
Date: Thu, 17 Nov 2022 11:35:43 +0000	[thread overview]
Message-ID: <87r0y1bypc.fsf@localhost> (raw)
In-Reply-To: <20220223193934.226994-1-necaris@gmail.com>

necaris@gmail.com writes:

> From: Rami Chowdhury <necaris@gmail.com>
>
> Previously, tables (i.e. lists-of-lists) came through as
> arrays-of-arrays. Since OCaml arrays are required to be homogeneous in
> their types, this meant tables with heterogenous types within a row
> could not be handled. This change represents tables as arrays of tuples,
> which is more flexible, while preserving the previous behavior for
> lists.

Thanks for the patch, and sorry for the late reply.

The idea looks reasonable. However, the proposed change will break the
existing code that relies on the current behaviour.

Would it be possible to auto-detect when the types are homogeneous and
use arrays? Otherwise, use tuples, as you proposed.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

     prev parent reply	other threads:[~2022-11-17 11:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 19:39 [PATCH] Send table rows to OCaml as tuples necaris
2022-11-17 11:35 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0y1bypc.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=necaris@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).