From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id P9CsFAutiWP7MgAAbAwnHQ (envelope-from ) for ; Fri, 02 Dec 2022 08:45:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UPa+EwutiWOtagEAauVa8A (envelope-from ) for ; Fri, 02 Dec 2022 08:45:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3746442CA7 for ; Fri, 2 Dec 2022 08:45:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p10ix-0000o2-Oy; Fri, 02 Dec 2022 02:44:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p10iv-0000ng-8C for emacs-orgmode@gnu.org; Fri, 02 Dec 2022 02:44:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p10iu-0004wZ-Tj; Fri, 02 Dec 2022 02:44:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Y8BsQzh/dBTMcQ+Q1DEdVt2dTnlDhJZY0NlcfjWjqEc=; b=ho/DKgUTaQP4h8DvhBF6 yuDvr3STbx53K54N60+q+Sr9HFAGatY1mBTs2rNjFAaUOblMPGz7xdESIBA+Ps5+JXZSiTrlzfcrU YnldogIbcOnAj4C2qTknyaDWQJkvAwuO3Eg5MMMtG+H9wrCL6q58YDYdOKP0PUsWnUSTqmiCIMygX cmbfdJKRBI2dBsHsqFgGHUE/2U3XCDGVqdZdI0DuEcFjUashPq5sWUl15rLO2OHntYLPSWDJ3sncr 332L0GduPyhtH15BBbDAz3yOFdzQyUSYhsaWL6i/27rmjJpnWtfPJMfYb41KifXOiSOVztUC4gXWB vNfZbBRMEpH+cQ==; Received: from 222.197.23.93.rev.sfr.net ([93.23.197.222] helo=hal) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p10it-0002Y9-K6; Fri, 02 Dec 2022 02:44:40 -0500 Received: by hal (Postfix, from userid 1000) id 106461E040E; Fri, 2 Dec 2022 08:44:36 +0100 (CET) From: Bastien To: Kyle Meyer Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Autoload `org-assert-version' and remove org-loaddefs.el In-Reply-To: <874juewk4k.fsf@kyleam.com> (Kyle Meyer's message of "Thu, 01 Dec 2022 22:38:03 -0500") Organization: GNU References: <874juewk4k.fsf@kyleam.com> Date: Fri, 02 Dec 2022 08:44:36 +0100 Message-ID: <87r0xi5jx7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-TUID: U0vjjo3ICDlG Kyle Meyer writes: >> This patch autoloads `org-assert-version'. > > I don't understand the rationale behind this. It was my naive attempt at fixing the "invalid-function org-assert-version" error several people reported. > Every spot that calls > org-assert-version is preceded by a line that requires org-macs, so > isn't this error likely due to a mixed installation/load-path issue > where the wrong/older org-macs is taking precedence? Yes: I thought `org-assert-version' job was to help catching mixed installations, so my reasoning was that, even when an old org-macs version has been loaded, autoloading `org-assert-version' would help report about mixed installation. Also you're right about org-loaddefs.el, we should keep it. That said, do you have any idea how to fix the bug people encounter when installing Org from ELPA and being bitten by "invalid-function org-assert-version"? -- Bastien