From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4BcYDvcf0GM43gAAbAwnHQ (envelope-from ) for ; Tue, 24 Jan 2023 19:14:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6BRBDfcf0GOqOQAAG6o9tA (envelope-from ) for ; Tue, 24 Jan 2023 19:14:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AB3EB3FFD6 for ; Tue, 24 Jan 2023 19:14:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKNnS-0002L2-Nc; Tue, 24 Jan 2023 13:13:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKNnK-0002Kq-PI for emacs-orgmode@gnu.org; Tue, 24 Jan 2023 13:13:18 -0500 Received: from mail-yqbcan01on20703.outbound.protection.outlook.com ([2a01:111:f403:7052::703] helo=CAN01-YQB-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKNnI-0008IP-R2 for emacs-orgmode@gnu.org; Tue, 24 Jan 2023 13:13:18 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mSxw3XaRaPyUbENRGAkO2xHH1VzDUxb2uaclkGv9s5nRbPjl6TwLKc8YQuw/Sj5ol6+5d47t9ePYpWM4DW9LrMpS8wwBbDlfapmchPdNTzQ/clAV0GuAAaUy3NlFLOp+r9hcCkexue6rE1ip1zAHsKczEcTU7ks6AACZ3Hn0v5JcX8SBcQfmS4dcd6Jtsj4jNizYU6rseTqFZxvj/gCZ6VU1cQUs4iN6bfvRGK/RAcMyeJBCr0Nwni0DHuoJp4Qzw5QoWVX4AKBXju4oQl9KIFnu/O1+D47NCOm704SyfZt4Rllbv169vwT0mvaiOJoiSRSiJKrUp/YobEDpThImBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fyDN/PbT0lJ3nm8OGSeLvpLlimzV2q+J77+8yRC30ok=; b=YyBn5nmM9JDZtwqmuLy1n+sSNcafLlkGAL6dyQPWupUE8NWIw77+uM9ZBFUKh+58C+epOzUwn7S6hiV2qIDhVmM3h0irgzRRQenttcdeX+wqRQFlpYbsqm3vhK0GMQyYMmuZgwm63+H3SvfkmUrzbrmFP4529BQ7+y5D94MoKwTxJI/uulFIueI3SbEdXTAp1M7Bjfye2aGeqohuGiPM/2ja6SocbEc2FyG9YX1oLOtEB44mnVb8KVVzeXv8kundimHcSyrDn0qx2RFst4gr1T++6qRjns1sgPm+aE4UY9EldpZY8ZPKqV/p9tHLpayJFwvgIIFlyVQyeu7mAixKqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=umanitoba.ca; dmarc=pass action=none header.from=umanitoba.ca; dkim=pass header.d=umanitoba.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umanitoba.onmicrosoft.com; s=selector2-umanitoba-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fyDN/PbT0lJ3nm8OGSeLvpLlimzV2q+J77+8yRC30ok=; b=PqCalQWbI9J+8b9W5wMXcnOS1VEOjb12H7rURRcrJoDKyLl96KlYx83TkNAapcutLTEZ0vXf0i+7aTj3VGCOdezomlR6ULykzzQi7IXbB+tFiOauqQMCxxP+NSYMGEiix7bBDuM8SUF6qv5QJCNVkOYIPkP6LKFU88/r0GQ1Wso= Received: from YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:90::5) by YT2PR01MB5982.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:5a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Tue, 24 Jan 2023 18:08:10 +0000 Received: from YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM ([fe80::4809:b686:dd5c:b1fd]) by YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM ([fe80::4809:b686:dd5c:b1fd%9]) with mapi id 15.20.6002.033; Tue, 24 Jan 2023 18:08:10 +0000 From: Leo Butler To: Ihor Radchenko CC: Org Mode Mailing List Subject: Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects Thread-Topic: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects Thread-Index: AQHY8srL9HYY78NwOki4MB+cHbDIhw== Date: Tue, 24 Jan 2023 18:08:10 +0000 Message-ID: <87r0vjbyba.fsf@t14.reltub.ca> References: <87mt92elyy.fsf@t14.reltub.ca> <87mt9128sz.fsf@localhost> <87zgd1b4rn.fsf_-_@t14.reltub.ca> <8735asbtfe.fsf@localhost> <87pmdvamwf.fsf@t14.reltub.ca> <87bkpaguy3.fsf@localhost> <87leocuhpg.fsf@t14.reltub.ca> <87359esah2.fsf@localhost> <87cz8ifioa.fsf@localhost> <87sfh9vukl.fsf@localhost> <87fsd7wolt.fsf@t14.reltub.ca> <87r0wk29dz.fsf@localhost> <87358ywn5g.fsf@localhost> <87bknh5nva.fsf@localhost> <87358ovj53.fsf@t14.reltub.ca> <87a62vitpu.fsf@localhost> <87lemfqbwl.fsf@t14.reltub.ca> <87o7r6m8sf.fsf@t14.reltub.ca> <87fschfhke.fsf@localhost> <87mt6m5n6u.fsf@localhost> <8735817d8s.fsf@localhost> In-Reply-To: <8735817d8s.fsf@localhost> (Ihor Radchenko's message of "Mon, 23 Jan 2023 10:32:19 +0000") Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: YT3PR01MB9964:EE_|YT2PR01MB5982:EE_ x-ms-office365-filtering-correlation-id: 230ec966-51ce-4f79-f241-08dafe35f3b1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aBfcOPXo7ZsiGeTAq1zvncQHjoy+0SDLjRb3Na8FLrlN9yGpJ3UGLbvE+rc7i4Y5Q+paFqWyLRVj/M1+/Z1/IZTESYOotAghiOtFK4u6yfC6nOB3xDKaE40WSQg6MG9Dy4JP9VNbGK40r7DNCxXsoBg0m5eQlMetQrID1+H+zascER4MXoGtMGTk6Nm7/B9R1nAoLLjxpoXZnb1xYn/TGNLvD6sQa06j6jEdv1BFaHKWVjh/ThdbHOy2xgw7fbBO0KvR4zVGflev4CnlWr1VuH0awJiL57EkBVWyo2HCqqovg02un13leUoAxt1rv5cqLjh3BgryQVjmmm3wIrbuhH8XQJpIewlZMb9uVhzPg0yLznwFVF8mBzf2fur8+cOruk6zjKdFHref5WUanbDMx+A95FB4uQqsEbbVvBLaCQp1AbXsqMnZDch3CruetraItTIyK/i1XIPVAKklrl2fZ0/LsLwIKzwS4QxkFrOB6E6xXSYf3Rt71Adz1l7/nHrCoVVM/VnetDHxCcd3f3vUTyWYm5cc/tw/vDPgtPN7CL7Kku7dAVgldjEM0IYfZCybLWcWAxu04bFnN/gMC7JuZ+mdAFteXOnov7iHcRUHetWZkYgG2isqZPrRe2sVBXen30C+eqOPtAo5RODhtY5Z9LeKMkiGbiwOL07Wh1kZfmE6iW/ooARCyOXUIVVeuhcEMxJ9nch4EhcMLVltohtxTCozCNuTyd6Kd7nMXusX864= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(346002)(136003)(39860400002)(376002)(451199015)(122000001)(38100700002)(83380400001)(38070700005)(41300700001)(86362001)(5660300002)(2906002)(8936002)(4326008)(316002)(6512007)(6506007)(26005)(6916009)(41320700001)(8676002)(186003)(66476007)(66556008)(9686003)(76116006)(66446008)(64756008)(786003)(478600001)(966005)(91956017)(71200400001)(6486002)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?OzEBsg2LbrK+sDukCAPmsWc4E+ezej6kC7l4+g/XTyZAU57hMGqBOHLz7M?= =?iso-8859-1?Q?vd1jo/KsMrO5jRJkfrIqivZmEY77A8ZAgKNixfYFopCrnrEdcfTHmL9l0j?= =?iso-8859-1?Q?kL/kbtPeWfBl5JMXrxUUuTq70ImxIfhlCBh3RoJvgvXe0ldIU1qox8PeZL?= =?iso-8859-1?Q?Jw8vJFbHY4uXyq4aVGsUKHyMkUVo4CtDFdEPdZjO4raemWcckWDm2zX4tH?= =?iso-8859-1?Q?qbgeJKr8orlqv30/ntxbmliVSc+y06h8lB3luGs3zkW9R9iovVcNukmJd1?= =?iso-8859-1?Q?gKns76HPIgn+Ac4eJGv7k87pS6KFUMfKNBF0T6BDYJcFxrq/UWhbmx1oev?= =?iso-8859-1?Q?zRq7uW34685ZVl+8wDfz6Lk/dZI8igoT2qrE16FlaiY81Lh5qeKN27d06b?= =?iso-8859-1?Q?4bviWDNSrTTjg3KsUdgYYTu7EpK2RZMZf3vaUA+Mf0SXBefLYFyXvllX++?= =?iso-8859-1?Q?fLDEzjmXlgAk+DnTFtJXzucQdLhTQgkoS/fCGlxHbI5z87pXaGpH+ZDb2C?= =?iso-8859-1?Q?uprhkBUt2HQ/eGrV6GVkpYsetBuXmSOYt23awmXTWDUmWrfTIlto7plhvr?= =?iso-8859-1?Q?0af++uWm5PXSz+XeeOhbrn0P1tyrUd3fF0RUCHOl9Y/flarP0HVVa2KdG4?= =?iso-8859-1?Q?0ujaqSBEQxXMG8ejYwtcKrjHbQDGsysZiHOG13jo7tflzB0RympzIDpFJc?= =?iso-8859-1?Q?cH+kRAqak3XiO1bvC31YykaE6VYOI5ZR53MOe7fF0pjP2gWmJlMjMhd2Ym?= =?iso-8859-1?Q?wcEOn5/nHGHqSYPGTcXPNMHjpWE/9Zz4XykcILh6QaFN4Bk2hgLyNPSicH?= =?iso-8859-1?Q?lmJOxcLBO8qBRoDtfoWLAx9190wm6Tt3NHNuQ8tC5+4BsEBx78cc1vx7Sa?= =?iso-8859-1?Q?yGQwK+/zBjQM3N+Rfiy0IIhtk/5Ff/Iv+MlvYPC4vVtTssL9C5ZgFef1Dk?= =?iso-8859-1?Q?okQvGGYyHCVq1FFIaBseZjMHqzsOQtlCZJkS1ZKamzuRYMCuPZ0KGL7+Vr?= =?iso-8859-1?Q?FNVzY8lGjPBbFTZZdH63b0iPrMZ/DZ6i4tppvgWI7fwcg/ZgIWYPrKBCCr?= =?iso-8859-1?Q?ZX9ggvM32pGeUnG4wb5AM5OgwAWlXBtJPW059/Q6fW09p03my3hzZQG0VO?= =?iso-8859-1?Q?mI9JZnXnb0EhbUmabW8n9JT2FwvufnHTrGl9b7z/HdAhsCQfx9DRKz/+r+?= =?iso-8859-1?Q?ukGT+3DIi2Nit/vG8xKGky6pSxvV1AkqiDHPTfE3tNmew+RsnvfWg+xONj?= =?iso-8859-1?Q?AphST9kby0tMtv3PYZUjOrkvWNxXjjg/JpG/k6PLudRHzbFL5JxmQZY+jE?= =?iso-8859-1?Q?d+9thUT787VKkkoQi/a+77Zu73wXdgPZ9CMhWV0qzyp2nLiBZrAhueQvQ2?= =?iso-8859-1?Q?fNixSXHxTNonihVRbDkFYg5fkFwgDzwg0sq/EynBhsd1A5Tft+BE20NNuq?= =?iso-8859-1?Q?ok+uZhDGPD74+4oGdWuLCCwCCOcUkwUYyR6b3ROEOBo/ntwnCOm/JrqpfQ?= =?iso-8859-1?Q?f21+6Pnwpdp77zTTM1GE1Hl5ydvc19dKSlQWYzwMbyz1GAUONpEBKypySp?= =?iso-8859-1?Q?NAipMvvnW/dkNVbjXNBu1IM88gOBXsnYbVqxxrjeZSW5z1JHmabgP989zC?= =?iso-8859-1?Q?NKm3U719FK9bzCXG2acL5uQzbdDaPqJf1vGc0gb5xaq+VUHGBPIPMHGA?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: umanitoba.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 230ec966-51ce-4f79-f241-08dafe35f3b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2023 18:08:10.0968 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4f80dd0b-338c-4e4c-8a14-90446962f7b8 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8CkMH/w0f3dSVJvtQVl7sgndPWewlAizwW2O8BrOx/u3d3cVlpu5QQ35hV7WEEO+1QWFKYlcrOgUc1NCEhvUjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB5982 Received-SPF: pass client-ip=2a01:111:f403:7052::703; envelope-from=Leo.Butler@umanitoba.ca; helo=CAN01-YQB-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674584054; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=fyDN/PbT0lJ3nm8OGSeLvpLlimzV2q+J77+8yRC30ok=; b=TPyFzCY9kDNk1YOWyraMpfvt/l2SBGEfL0df7BNOSPp4fMntjijqceERXGRgYzkuFO1gB2 v3DZV6CVj88hBazezYfpNUH6M9tG4SiZFBFI/sJaFDyKgcsLWGdRZUTIiXqKnTC+xawkq6 2DttVDCWs0QL7z6HUhGerm5MUHEDVXK1vK2Oex5XZ5gwcOADTAWtrZSpd8aC20+/fmseO4 6ztyRCp2VZOeLaiT6Dq6co4gujkxM0upWqAttgVCMGSdNj5+uh+Sfe/IIH47omdz969hiW jm7wlcbtv1Q8hx8f5K6dHV4pxe6pfPt9JYcsHoBRixznix5fpInBd5eKLFemzA== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=umanitoba.onmicrosoft.com header.s=selector2-umanitoba-onmicrosoft-com header.b=PqCalQWb; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=2; s=key1; d=yhetil.org; t=1674584054; a=rsa-sha256; cv=pass; b=tFqH39WvMOvwDoQrrzD3VyPewlxAkjPYkenXlfgJQRjh7Mcq/2TNyqXuIu5rgkCUmOCvAa EF3677SyAzHTuTJQT4uwZ41emIbc0axWkV+f4Xz9tBJVgGnQtDVM5+qd6buEkpcCjWTwu3 tKIhsZcB3hcbDPccxpHGd8Cqzkf6WsXdGZDs/fTcMCFRHbMth252ZnAxYKX2jh6nk8Q8eG p+Eu545YfTOHFjWPDDELvpmSG+UKspFBbd556yiunkHujX8n3TJ28XWDfZyDEVa5AyTnYp dITD7MFthsOyLEP+9DhLj0MG0je/AWGMkAcyXMHUU7qgVSLHzXRBwF8ByDa6ZA== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=umanitoba.onmicrosoft.com header.s=selector2-umanitoba-onmicrosoft-com header.b=PqCalQWb; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -5.31 X-Spam-Score: -5.31 X-Migadu-Queue-Id: AB3EB3FFD6 X-TUID: sIy8vmHGwH3+ On Mon, Jan 23 2023, Ihor Radchenko wrote: > Ihor Radchenko writes: > >> Ihor Radchenko writes: >> >>> So, the test failure is real. >> >> The error buffer contents when the test fails is the following: >> >> warning: using the gnuplot graphics toolkit is discouraged >> ... >> [ Babel evaluation exited with code 0 ] >> >> Exit code is 0, so octave does finish. >> >> Hence, test assertion that >> (should-not (buffer-live-p (get-buffer "*Org-Babel Error Output*"))) >> does not appear to be accurate. >> >> Leo, should we simply remove the assertion? > > I decided to remove the assertion from the tests. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3D59228e5= 1345ab522d9db611c8e73caa078d86d2f > > While there could be a value in making sure that ob-octave calls octave > without generating errors, it is not strictly what the test is checking > for. > > Moreover, we currently have no reliable way to disambiguate mere > warnings from non-zero exit code. Yes, as I said in a previous email, I can live with that. The origin of the errors that you documented is not, I believe, due to either of the causes suggested by either Max or you. But, investigating obscure test failures like this is probably not the best expenditure of time and effort. Best regards, Leo=