emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: "Max Nikulin" <manikulin@gmail.com>, "Rudolf Adamkovič" <salutis@me.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-clock: Add a trailing space to the mode line string
Date: Fri, 03 Mar 2023 16:00:14 +0000	[thread overview]
Message-ID: <87r0u54ygh.fsf@localhost> (raw)
In-Reply-To: <ttqkfl$3d2$1@ciao.gmane.io>

Max Nikulin <manikulin@gmail.com> writes:

> On 02/03/2023 21:14, Rudolf Adamkovič wrote:
>> +++ b/lisp/org-clock.el
>> @@ -728,9 +728,9 @@ If not, show simply the clocked time like 01:50."
>>   				'org-mode-line-clock-overrun
>>   			      'org-mode-line-clock)))
>>   	       (effort-str (org-duration-from-minutes effort-in-minutes)))
>> -	  (format (propertize " [%s/%s] (%s)" 'face 'org-mode-line-clock)
>> +	  (format (propertize " [%s/%s] (%s) " 'face 'org-mode-line-clock)
>
> Previous discussion of spaces in mode-line:
>
> Ihor Radchenko to emacs-orgmode… Re: Weird gap in agenda mode-line. Sun, 
> 14 Nov 2021 15:52:31 +0800. 
> https://list.orgmode.org/87k0hbdvi8.fsf@localhost
>
> It seems agenda components use leading spaces but no trailing ones. I am 
> not familiar with mode line formatting, so it may be a false alarm.

It is because they are a part of mode string. Leading space is a
convention for minor modes.

M-x display-time-mode does the opposite - trailing space.

Rudolf, I am OK with the patch, but could you please add a comment
explaining why trailing space, so that people do not wonder in future?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2023-03-03 16:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02 14:14 [PATCH] org-clock: Add a trailing space to the mode line string Rudolf Adamkovič
2023-03-02 16:56 ` Max Nikulin
2023-03-03 16:00   ` Ihor Radchenko [this message]
2023-03-03 21:03     ` Rudolf Adamkovič
2023-03-04  2:30       ` Max Nikulin
2023-03-04 21:14         ` Rudolf Adamkovič
2023-03-05 12:22       ` Ihor Radchenko
2023-03-05 19:45         ` Rudolf Adamkovič
2023-03-07 13:05           ` Ihor Radchenko
2023-03-07 21:17             ` Rudolf Adamkovič

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0u54ygh.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=manikulin@gmail.com \
    --cc=salutis@me.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).