From: Ihor Radchenko <yantar92@posteo.net>
To: Anand Deopurkar <anandrdeopurkar@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-archive.el: Fix org-add-archive-files to correctly de-duplicate
Date: Sat, 02 Mar 2024 12:28:00 +0000 [thread overview]
Message-ID: <87r0gs6cof.fsf@localhost> (raw)
In-Reply-To: <87wmqkap27.fsf@gmail.com>
Anand Deopurkar <anandrdeopurkar@gmail.com> writes:
> Subject: [PATCH] org-archive.el: Fix org-add-archive-files to correctly
> de-duplicate
>
> * org-archive.el (org-add-archive-files): Use `seq-uniq' with TESTFN
> `\#\'file-equal-p' to de-duplicate the list of gathered files.
>
> Previously, `org-uniquify' was used. This de-duplicates the
> file-names, but not necessarily the files. The problem occurs if the
> list of file-names includes distinct file-names that reference the
> same file (symbolic links, for example).
Thanks for the patch!
Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=902dacb9c
I also added you to the contributor list.
https://git.sr.ht/~bzg/worg/commit/58d6aca1
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2024-03-02 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 10:46 [PATCH] org-archive.el: Fix org-add-archive-files to correctly de-duplicate Anand Deopurkar
2024-03-02 12:28 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0gs6cof.fsf@localhost \
--to=yantar92@posteo.net \
--cc=anandrdeopurkar@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).