From: Suhail Singh <suhailsingh247@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Suhail Singh <suhailsingh247@gmail.com>,
TEC <orgmode@tec.tecosaur.net>,
Org mailing list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks
Date: Mon, 22 Jul 2024 13:11:04 -0400 [thread overview]
Message-ID: <87r0bl2vyv.fsf@gmail.com> (raw)
In-Reply-To: <87le1tmt8w.fsf@localhost> (Ihor Radchenko's message of "Mon, 22 Jul 2024 13:49:35 +0000")
Ihor Radchenko <yantar92@posteo.net> writes:
> Please address my concern about :textarea attribute. I do not see why
> we should ignore it here.
I don't understand your concern. Could you please elaborate on what you
mean by "why we should ignore it here"? What is the "it" and what is
the "here"?
From your email on 18th June:
> I am not sure if we want to add all the attributes to every transcoded
> element. At least in some cases, we do discard them
> (`org-html--textarea-block').
From the manual:
#+CAPTION: [[info:org#Text areas in HTML export][org#Text areas in HTML export]]
#+begin_quote
The HTML export backend can create such text areas. It requires an
‘#+ATTR_HTML’ line as shown in the example below with the ‘:textarea’
option. This must be followed by either an example or a source code
block. Other Org block types do not honor the ‘:textarea’ option.
#+end_quote
The current processing of :textarea does special handling for width and
height attributes and discards the rest (based on my understanding of
the code in `org-html--textarea-block'). Said support for :textarea
attribute exists in `org-html-src-block' and `org-html-example-block'
which is consistent with the manual.
The patches I shared did not interfere with the handling of :textarea in
the blocks that support it.
In order to make the code more robust, one may wish to remove :textarea
from the list of attributes (or issue a user-error or warning if it's
present) in blocks that were never intended to support it (such as
`org-html-fixed-width'). I do not have any opinion on this matter.
Similarly, one may wish to add additional error checking based on the
specifics of the transcoded element. I do not believe this to be
worthwhile (HTML validation often has errors, and if a user is so
interested they always have the option of validating the generated
HTML).
There is an open question regarding what attributes to support in
`org-html--textarea-block' (i.e., in the presence of `:textarea'
option). I believe the "correct" thing would be to filter out `:width'
and `:height' (since, if present, they are translated into `rows' and
`cols' attributes in the generated HTML) and include the rest "as is" in
the generated HTML
Regardless of the specifics above regd. :textarea, I believe support for
#+ATTR_HTML ought to be added for most blocks to allow for CSS class
and/or inline style to be specified when exporting to HTML.
Additionally, I consider the absence of such support to be a bug.
--
Suhail
next prev parent reply other threads:[~2024-07-22 17:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 2:55 [PATCH] [BUG] Support attr_html in source code and fixed-width blocks Suhail Singh
2024-06-18 15:33 ` Ihor Radchenko
2024-07-19 15:28 ` Suhail Singh
2024-07-22 13:49 ` Ihor Radchenko
2024-07-22 17:11 ` Suhail Singh [this message]
2024-07-22 18:13 ` Ihor Radchenko
2024-07-22 18:45 ` Suhail Singh
2024-07-22 19:10 ` Ihor Radchenko
2024-07-22 19:35 ` Suhail Singh
2024-07-22 19:49 ` Ihor Radchenko
2024-07-22 20:05 ` Suhail Singh
2024-09-02 13:03 ` Suhail Singh
2024-09-07 18:10 ` Ihor Radchenko
2024-09-07 19:45 ` Suhail Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0bl2vyv.fsf@gmail.com \
--to=suhailsingh247@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=orgmode@tec.tecosaur.net \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).