* [Bug] Documentation error(s) for org-babel-tangle-default-file-mode
@ 2024-12-19 19:21 Aitenate
2024-12-22 16:54 ` Ihor Radchenko
0 siblings, 1 reply; 2+ messages in thread
From: Aitenate @ 2024-12-19 19:21 UTC (permalink / raw)
To: emacs-orgmode
I think there a couple of issues with the documentation for
org-babel-tangle-default-file-mode. It seemed easiest to describe using
a patch:
diff --git a/doc/org-manual.org b/doc/org-manual.org
index 0f6d6a067..7d703993f 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -19521,7 +19521,7 @@ unexpected results (=444= is the same as =o674=).
Two other shorthands are recognized, ls-style strings like
=rw-r--r--=, and chmod-style permissions like =g+w=.
Note that chmod-style permissions are based on
-~org-babel-tangle-default-file-mode~, which is =#o544= by default.
+~org-babel-tangle-default-file-mode~, which is =#o644= by default.
When =:tangle-mode= and =:shebang= are both specified, the give
=:tangle-mode= will override the permissions from =:shebang=. When
diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el
index fe353ec9c..c35525162 100644
--- a/lisp/ob-tangle.el
+++ b/lisp/ob-tangle.el
@@ -159,9 +159,10 @@ result. The default value is
`org-remove-indentation'."
:type 'function)
(defcustom org-babel-tangle-default-file-mode #o644
- "The default mode used for tangled files, as an integer.
-The default value 420 correspands to the octal #o644, which is
-read-write permissions for the user, read-only for everyone else."
+ "The default mode, an integer value, only used when the :tangle-mode
+header argument specifies chmod-style symbolic notation. The default
+value 420 corresponds to the octal #o644, which is read-write
+permissions for the user, read-only for everyone else."
:group 'org-babel-tangle
:package-version '(Org . "9.6")
:type 'integer)
If I've misread something, apologies for the noise.
Regards,
Aitenate
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Bug] Documentation error(s) for org-babel-tangle-default-file-mode
2024-12-19 19:21 [Bug] Documentation error(s) for org-babel-tangle-default-file-mode Aitenate
@ 2024-12-22 16:54 ` Ihor Radchenko
0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2024-12-22 16:54 UTC (permalink / raw)
To: Aitenate; +Cc: emacs-orgmode
Aitenate <aitenate@outlook.com> writes:
> I think there a couple of issues with the documentation for
> org-babel-tangle-default-file-mode. It seemed easiest to describe using
> a patch:
Thanks!
Applied, onto bugfix, after adding a proper commit message and a
TINYCHANGE cookie.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=2607c40c025bb52e371ec88c0914543cd0c04f1f
I also added you to the list of Org mode contributors:
https://git.sr.ht/~bzg/worg/commit/0687532a096569c545b44b052aa21ab6bf3de015
Fixed.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-22 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-19 19:21 [Bug] Documentation error(s) for org-babel-tangle-default-file-mode Aitenate
2024-12-22 16:54 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).