emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Matt Lundin <mdl@imapmail.org>
To: Roland Winkler <winkler@gnu.org>
Cc: emacs-orgmode@gnu.org, bbdb-info@lists.sourceforge.net
Subject: Re: org-bbdb-anniversaries gives error 'bad sexp'
Date: Mon, 16 May 2011 10:03:46 -0400	[thread overview]
Message-ID: <87pqnivj25.fsf@fastmail.fm> (raw)
In-Reply-To: <19920.3805.453866.486816@gargle.gargle.HOWL> (Roland Winkler's message of "Sun, 15 May 2011 12:35:25 -0500")

"Roland Winkler" <winkler@gnu.org> writes:

> On Sun May 15 2011 Matt Lundin wrote:
>> I'd be happy to take this on. AFAICT, there are three functions in
>> org-bbdb that no longer exist in bbdb v3.
>> 
>> bbdb-name
>> bbdb-company
>> bbdb-record-getprop
>> 
>> The first two can easily be defaliased to bbdb-search-organization and
>> bbdb-search-name. (For a while, we should probably support bbdb v2 and
>> v3 simultaneously.)
>
> Things might be a bit more subtle. The new organization field is
> a list, not a single string.

Thanks. That's good to know. AFAICT, bbdb-search-organization already
accommodates for this fact. That is, if you give it a regexp, it will
return all records matching the regexp in the organization field. Since
org-bbdb calls bbdb-company with a string as an argument, wouldn't a
defalias be sufficient for the time being?

>> The other major change that breaks compatibility is the order of the
>> parameters in bbdb-split. It has been reversed in the new bbdb: i.e.,
>> one used to call (bbdb-split string separator), whereas now one must
>> call (bbdb-split separator string). Is there a compelling reason to
>> change this order in the new bbdb?
>
> The change is not only with respect to the order of arguments that
> could be reverted in BBDB v3. More importantly, I tried to get rid
> of hard-coded separators. Most often the separator arg is now the
> name of the field that is split. Then the actual separator is looked
> up in bbdb-separator-alist. While I do not know yet a good strategy
> for the upgrade of org-mode's BBDB interface, I'd find it
> unfortunate if such a feature was lost in org-mode to preserve
> backward compatibility.

Thanks for the explanation. For the time being, I'll add a workaround to
accommodate both versions.

Best,
Matt

next prev parent reply	other threads:[~2011-05-16 14:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87wrht82iw.fsf@gmx.co.uk>
2011-05-15 16:02 ` org-bbdb-anniversaries gives error 'bad sexp' Roland Winkler
2011-05-15 16:13   ` Roland Winkler
2011-05-15 16:58   ` Matt Lundin
2011-05-15 17:35     ` Roland Winkler
2011-05-16 14:03       ` Matt Lundin [this message]
2011-05-15 18:18     ` Leo
2011-05-16 14:08       ` Matt Lundin
2011-06-12 23:36         ` Philipp Haselwarter
2011-06-13  4:40           ` Nick Dokos
2011-06-13 12:27           ` Matt Lundin
2011-06-13 16:15             ` Philipp Haselwarter
2011-06-15 14:32               ` Carsten Dominik
2011-06-15 19:13                 ` [bug] Problem with insert anniversary agenda function (was Re: org-bbdb-anniversaries gives error 'bad sexp') Eric S Fraga
2011-06-16  8:04                   ` [patch] " Eric S Fraga
2011-06-16 12:41                     ` Carsten Dominik
2011-06-20  7:41                       ` Eric S Fraga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pqnivj25.fsf@fastmail.fm \
    --to=mdl@imapmail.org \
    --cc=bbdb-info@lists.sourceforge.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=winkler@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).