emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bernt Hansen <bernt@norang.ca>
To: Michael Brand <michael.ch.brand@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Agenda: Simplify old fix of face for deadline warning 0 day
Date: Thu, 04 Aug 2011 20:18:43 -0400	[thread overview]
Message-ID: <87pqkkbti4.fsf@norang.ca> (raw)
In-Reply-To: <CALn3zog9z_PLHu-iF-dR1cGmQBE2YU+Wc=DvikLzpc-+YE5mJg@mail.gmail.com> (Michael Brand's message of "Mon, 1 Aug 2011 10:57:13 +0200")

Michael Brand <michael.ch.brand@gmail.com> writes:

> Agenda: Simplify old fix of face for deadline warning 0 day
>
> * lisp/org-agenda.el (org-agenda-get-deadlines): Fix dfrac for the
> case of wdays being 0.  Don't pass wdays to org-agenda-deadline-face,
> like before the old fix.
> (org-agenda-deadline-face): Revert to old state that was without
> wdays.
>
> This allows a deadline warning period of "-0d" to work also with a
> custom configuration like:
> (setq org-agenda-deadline-faces
>       '((1.0001 . org-warning)              ; due yesterday or before
>         (0.0    . org-upcoming-deadline)))  ; due today or later
> For org-agenda-deadline-faces left at default and all other settings
> not exceeding 1.0, the face for a deadline warning of any length
> remains untouched by this patch.
>
> references to history:
> * commit of the old fix
>   - http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=d0d6325
>   - git show d0d6325
> * mailing list old thread
>   - http://thread.gmane.org/gmane.emacs.orgmode/5753
>   - http://lists.gnu.org/archive/html/emacs-orgmode/2008-02/msg00395.html

This patch works okay for me with my default setting of

,----
| org-agenda-deadline-faces is a variable defined in `org-faces.el'.
| Its value is 
| ((1.0 . org-warning)
|  (0.5 . org-upcoming-deadline)
|  (0.0 . default))
`----

Regards,
Bernt

next prev parent reply	other threads:[~2011-08-05  0:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-01  8:57 [PATCH] Agenda: Simplify old fix of face for deadline warning 0 day Michael Brand
2011-08-05  0:18 ` Bernt Hansen [this message]
2011-08-14 16:42 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pqkkbti4.fsf@norang.ca \
    --to=bernt@norang.ca \
    --cc=emacs-orgmode@gnu.org \
    --cc=michael.ch.brand@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).