From: Bernt Hansen <bernt@norang.ca>
To: nicholas.dokos@hp.com
Cc: "=?utf-8?Q?Fran=C3=A7ois?=" Pinard <pinard@iro.umontreal.ca>,
emacs-orgmode@gnu.org
Subject: Re: org-publish-validate-link ?
Date: Tue, 28 Feb 2012 07:42:04 -0500 [thread overview]
Message-ID: <87pqczf7tv.fsf@norang.ca> (raw)
In-Reply-To: <7251.1330403983@alphaville> (Nick Dokos's message of "Mon, 27 Feb 2012 23:39:43 -0500")
Nick Dokos <nicholas.dokos@hp.com> writes:
> François Pinard <pinard@iro.umontreal.ca> wrote:
>
>
>> The manual, in [[info:org#Publishing%20links][Publishing links]],
>> speaks about an *org-publish-validate-link* function which does not seem
>> to exist in Org mode sources. Is the function missing, or the
>> documentation misleading? :-)
>>
>
> It was removed by Sebastian Rose in a cleaning binge back in 2010,
> with the rationale that it was not being used anywhere:
>
> ,----
> | commit 339d6fe4bbf7b9858c6323d01f32d0c73a4cd3a8
> | Author: Sebastian Rose <sebastian_rose@gmx.de>
> | Date: Thu May 13 13:43:53 2010 +0200
> |
> | ...
> |
> | * org-publish.el (org-publish-validate-link) was not used
> | anywhere. Removed.
> |
> | ...
> `----
>
> Apparently that had happened before because there is also this:
>
> ,----
> | commit d1f91f7e936b1d3caf1b17f0fe755ee085256442
> | Author: Carsten Dominik <carsten.dominik@gmail.com>
> | Date: Sun Nov 2 16:20:40 2008 +0100
> |
> | Re-introduce the org-publish-validate-link function.
> `----
>
> but I cannot find the previous deletion.
From
git log -Sdefun\ org-publish-validate-link
,----
| commit b05bc10e6794c902df679b906d8bd6ec3f5633a9
| Author: Bastien Guerry <bzg@altern.org>
| Date: Sun Mar 2 14:14:52 2008 +0000
|
| Cleaned up code.
|
`----
-Bernt
>
> It was originally introduced with the following commit:
>
> ,----
> | commit 8fd900c6842d6f8d216ae6989b34c8de4a874e79
> | Author: Carsten Dominik <dominik@nb-dominik2.science.uva.nl>
> | Date: Thu Jan 31 11:32:08 2008 +0100
> |
> | Release 4.40
> |
> | ...
> |
> | +;;;; Checking filenames against this hash
> | +
> | +
> | +(defun org-publish-validate-link (link)
> | + (gethash (file-truename link) org-publish-files))
> | +
> | +
> |
> | ...
> `----
>
> I presume it's time to add it back in, this time with a note: "Do NOT
> delete: this function may look unused, but it's referred to from the
> manual!"
>
> Archaelogy is kind of fun ;-)
>
> Nick
next prev parent reply other threads:[~2012-02-28 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 4:00 org-publish-validate-link ? François Pinard
2012-02-28 4:39 ` Nick Dokos
2012-02-28 12:42 ` Bernt Hansen [this message]
2012-02-28 13:04 ` Nick Dokos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqczf7tv.fsf@norang.ca \
--to=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
--cc=nicholas.dokos@hp.com \
--cc=pinard@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).