emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Eric Schulte <eric.schulte@gmx.com>
To: Andreas Leha <andreas.leha@med.uni-goettingen.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] link descriptions in :file results of src blocks
Date: Sat, 31 Mar 2012 15:01:12 -0400	[thread overview]
Message-ID: <87pqbswq6f.fsf@gmx.com> (raw)
In-Reply-To: <87vclky211.fsf@med.uni-goettingen.de> (Andreas Leha's message of "Sat, 31 Mar 2012 21:59:54 +0200")

[...]
>> I would like to apply this patch, however I have some questions about
>> the use of the :file argument and the result itself to fill in the
>> description if the :filelinkdescr header argument is left blank.  Also,
>> I would suggest that :file-desc is a better name for this header
>> argument.
>
> Hi Eric,
>
> thanks for considering this patch.  Feel free to change the term to
> anything more appropriate.
>
>>
>> In my opinion using the :file argument as a description changes (or at
>> least adds to) the meaning of the :file header argument.  Is there a
>> significant benefit to this behavior?  If not I'd prefer that an empty
>> :file-desc header argument have no effect.
>
> My original use case was indeed making a code block to
> produce [[file.pdf][file.pdf]] instead of [[file.pdf]] (see
> http://permalink.gmane.org/gmane.emacs.orgmode/53941).  So, if you
> remove the possibility to specify an empty :file-desc, for me that would
> mean to give the file name twice, as in
> : #+begin_src R :results graphics :file test2.png :file-desc test2.png
> which would be avoidable with my proposed behaviour.
>
> I could live with that, though I'd still prefer not to have to type more
> than necessary...
>

Makes sense, I've just pushed up a solution which builds on your initial
patch by

1. changing :filelinkdescr to :file-desc

2. when an empty :file-desc header argument is specified it's value is
   set to the value of the file path resulting in
   [[file.pdf][file.pdf]]

3. adding documentation and a test case

Please let me know if this misses any part of your intended use case.

Thanks for the contribution!

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

  reply	other threads:[~2012-03-31 21:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27  8:56 [PATCH] link descriptions in :file results of src blocks Andreas Leha
2012-03-27  9:16 ` Bastien
2012-03-31 14:09 ` Eric Schulte
2012-03-31 19:59   ` Andreas Leha
2012-03-31 19:01     ` Eric Schulte [this message]
2012-04-01  8:09       ` Andreas Leha
2012-04-01 12:38         ` Eric Schulte
2012-04-01 18:34           ` Andreas Leha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pqbswq6f.fsf@gmx.com \
    --to=eric.schulte@gmx.com \
    --cc=andreas.leha@med.uni-goettingen.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).