From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: [ox-latex] Bad default value for image width? Date: Wed, 10 Apr 2013 19:23:14 +0200 Message-ID: <87ppy2i9kt.fsf@pank.iue.private> References: <87haji85a7.fsf@pank.iue.private> <8761zv9xd0.fsf@gmail.com> <87y5cqiown.fsf@pank.iue.private> <87k3oasic2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:39425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPyk2-0003Q9-7C for emacs-orgmode@gnu.org; Wed, 10 Apr 2013 13:23:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPyk0-0004uW-Sb for emacs-orgmode@gnu.org; Wed, 10 Apr 2013 13:23:26 -0400 Received: from plane.gmane.org ([80.91.229.3]:52686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPyk0-0004u4-MC for emacs-orgmode@gnu.org; Wed, 10 Apr 2013 13:23:24 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UPyjx-0002Ss-MH for emacs-orgmode@gnu.org; Wed, 10 Apr 2013 19:23:21 +0200 Received: from ip-pool-130.iue.it ([192.167.90.140]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 10 Apr 2013 19:23:21 +0200 Received: from rasmus by ip-pool-130.iue.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 10 Apr 2013 19:23:21 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nicolas, Nicolas Goaziou writes: >> It's a bad default for >> - Picture smaller than textwidth >> - Picture crafted to the document which shouldn't have a width. >> >> It's a decent solution for >> - pictures which are unintentionally larger than textwidth. But IMO >> it's my responsibility, and not Org's, to fix these >> images/situations. > > Exactly. > > I'm not selling you the default value as the perfect solution: it isn't, > obviously. I even agree that in most situations, no default value is > better. Agree. > However, in my experience, the worst situation is the image (much) > larger than textwidth, which makes it difficult to even read the > produced document. It isn't as bad for enlarged small pictures. Perhaps. I'm not convinced. If the float width is removed I can change the default and never be affected by these design choices and it's all good. > Now, the ".7\textwidth" for floats is harder to explain. I don't feel > very strong about it, and I don't mind removing it (meaning > `org-latex-image-default-width' would also apply > to floats). Using org-latex-image-default-width is more reasonable IMO. Then at least there won't be any 'nasty' surprises when adding caption and for me I can set the default width to "" and be done with it. For people who use it it might also be reasonable to introduce a org-latex-wrap-image-default-width or making org-latex-image-default-width a list ordered by type of element/float type. E.g. '((float . ".9\\textwidth") (wrap . ".5\\textwidth")). . . >> I like the "" better. It works better with my "intuitive logic". > > I have pushed a patch which should fix your initial problem about :width > "" not being taken into account. Could you confirm the new behaviour > works as expected? I'll check it out and report back. I can't access git from this network (high port numbers are blocked for "security" reasons) so I'll only try it out later. Thanks, Rasmus. -- Hooray!