From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ecay Subject: Re: [RFC] [patch] open/delete attachment with inherited directory Date: Wed, 18 Dec 2013 00:11:13 -0500 Message-ID: <87ppoueob2.fsf@gmail.com> References: <874n69fkxc.fsf@gmail.com> <87sitr8jpd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vt9Po-0004oA-6c for emacs-orgmode@gnu.org; Wed, 18 Dec 2013 00:11:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vt9Pf-0005Hc-PU for emacs-orgmode@gnu.org; Wed, 18 Dec 2013 00:11:24 -0500 Received: from mail-qa0-x231.google.com ([2607:f8b0:400d:c00::231]:42029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vt9Pf-0005HY-LG for emacs-orgmode@gnu.org; Wed, 18 Dec 2013 00:11:15 -0500 Received: by mail-qa0-f49.google.com with SMTP id ii20so77226qab.1 for ; Tue, 17 Dec 2013 21:11:15 -0800 (PST) In-Reply-To: <87sitr8jpd.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou , emacs-orgmode@gnu.org Hi Nicolas, 2013ko abenudak 17an, Nicolas Goaziou-ek idatzi zuen: > > Thanks for the patch. > > I see one major problem, though. Org attach doesn't require to list > files attached to the entry (see `org-attach-file-list-property'). > Therefore, `org-entry-get-multivalued-property' could return nil even > though there are attached files. Hmm, good catch. Perhaps then we should read the property if it exists, but fall back to querying the filesystem in case it does not. WDYT? Thanks, -- Aaron Ecay