From: Bastien <bzg@gnu.org>
To: Rick Frankel <rick@rickster.com>
Cc: emacs-orgmode@gnu.org, schulte.eric@gmail.com
Subject: Re: [BUG] Testing fails after rename of ob-sh
Date: Fri, 17 Jan 2014 14:29:48 +0100 [thread overview]
Message-ID: <87ppnqpwhf.fsf@bzg.ath.cx> (raw)
In-Reply-To: <20140116224305.GA45120@eyeBook> (Rick Frankel's message of "Thu, 16 Jan 2014 17:43:06 -0500")
[-- Attachment #1: Type: text/plain, Size: 299 bytes --]
Hi Rick,
Rick Frankel <rick@rickster.com> writes:
> Eric-
>
> After doing a git pull including the rename of ob-sh.el to
> ob-shell.el, testing fails with the error:
>
> Cannot open load file: no such file or directory, ob-sh
The attached patch fixes it but I'll let Eric apply or amend it.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-ob-shell-tests.patch --]
[-- Type: text/x-diff, Size: 5037 bytes --]
Changes in stash@{0}^2^..stash@{0}
3 files changed, 53 insertions(+), 53 deletions(-)
testing/lisp/test-ob-sh.el | 52 -------------------------------------------
testing/lisp/test-ob-shell.el | 52 +++++++++++++++++++++++++++++++++++++++++++
testing/org-test.el | 2 +-
Deleted testing/lisp/test-ob-sh.el
diff --git a/testing/lisp/test-ob-sh.el b/testing/lisp/test-ob-sh.el
deleted file mode 100644
index 87e2a95..0000000
--- a/testing/lisp/test-ob-sh.el
+++ /dev/null
@@ -1,52 +0,0 @@
-;;; test-ob-sh.el
-
-;; Copyright (c) 2010-2014 Eric Schulte
-;; Authors: Eric Schulte
-
-;; This file is not part of GNU Emacs.
-
-;; This program is free software; you can redistribute it and/or modify
-;; it under the terms of the GNU General Public License as published by
-;; the Free Software Foundation, either version 3 of the License, or
-;; (at your option) any later version.
-
-;; This program is distributed in the hope that it will be useful,
-;; but WITHOUT ANY WARRANTY; without even the implied warranty of
-;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-;; GNU General Public License for more details.
-
-;; You should have received a copy of the GNU General Public License
-;; along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-;;; Comment:
-
-;; Template test file for Org-mode tests
-
-;;; Code:
-(org-test-for-executable "sh")
-(unless (featurep 'ob-shell)
- (signal 'missing-test-dependency "Support for Sh code blocks"))
-
-(ert-deftest test-ob-sh/dont-insert-spaces-on-expanded-bodies ()
- "Expanded shell bodies should not start with a blank line
-unless the body of the tangled block does."
- (should-not (string-match "^[\n\r][\t ]*[\n\r]"
- (org-babel-expand-body:generic "echo 2" '())))
- (should (string-match "^[\n\r][\t ]*[\n\r]"
- (org-babel-expand-body:generic "\n\necho 2" '()))))
-
-(ert-deftest test-ob-sh/dont-error-on-empty-results ()
- "Was throwing an elisp error when shell blocks threw errors and
-returned empty results."
- (should (null (org-babel-execute:sh "ls NoSuchFileOrDirectory.txt" nil))))
-
-(ert-deftest test-ob-sh/session ()
- "This also tests `org-babel-comint-with-output' in
-ob-comint.el, which was not previously tested."
- (let ((res (org-babel-execute:sh "echo 1; echo 2" '((:session . "yes")))))
- (should res)
- (should (listp res))))
-
-(provide 'test-ob-sh)
-
-;;; test-ob-sh.el ends here
New testing/lisp/test-ob-shell.el
diff --git a/testing/lisp/test-ob-shell.el b/testing/lisp/test-ob-shell.el
new file mode 100644
index 0000000..c2f2fa1
--- /dev/null
+++ b/testing/lisp/test-ob-shell.el
@@ -0,0 +1,52 @@
+;;; test-ob-shell.el
+
+;; Copyright (c) 2010-2014 Eric Schulte
+;; Authors: Eric Schulte
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software; you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+;;; Comment:
+
+;; Template test file for Org-mode tests
+
+;;; Code:
+(org-test-for-executable "sh")
+(unless (featurep 'ob-shell)
+ (signal 'missing-test-dependency "Support for Sh code blocks"))
+
+(ert-deftest test-ob-shell/dont-insert-spaces-on-expanded-bodies ()
+ "Expanded shell bodies should not start with a blank line
+unless the body of the tangled block does."
+ (should-not (string-match "^[\n\r][\t ]*[\n\r]"
+ (org-babel-expand-body:generic "echo 2" '())))
+ (should (string-match "^[\n\r][\t ]*[\n\r]"
+ (org-babel-expand-body:generic "\n\necho 2" '()))))
+
+(ert-deftest test-ob-shell/dont-error-on-empty-results ()
+ "Was throwing an elisp error when shell blocks threw errors and
+returned empty results."
+ (should (null (org-babel-execute:sh "ls NoSuchFileOrDirectory.txt" nil))))
+
+(ert-deftest test-ob-shell/session ()
+ "This also tests `org-babel-comint-with-output' in
+ob-comint.el, which was not previously tested."
+ (let ((res (org-babel-execute:sh "echo 1; echo 2" '((:session . "yes")))))
+ (should res)
+ (should (listp res))))
+
+(provide 'test-ob-shell)
+
+;;; test-ob-shell.el ends here
Modified testing/org-test.el
diff --git a/testing/org-test.el b/testing/org-test.el
index c2a9fd4..879d45e 100644
--- a/testing/org-test.el
+++ b/testing/org-test.el
@@ -52,7 +52,7 @@
(require 'org-id)
(require 'ox)
(org-babel-do-load-languages
- 'org-babel-load-languages '((sh . t) (org . t))))
+ 'org-babel-load-languages '((shell . t) (org . t))))
(let* ((load-path (cons
org-test-dir
[-- Attachment #3: Type: text/plain, Size: 14 bytes --]
--
Bastien
next prev parent reply other threads:[~2014-01-17 13:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 22:43 [BUG] Testing fails after rename of ob-sh Rick Frankel
2014-01-17 13:29 ` Bastien [this message]
2014-01-17 16:44 ` Achim Gratz
2014-01-17 17:34 ` Eric Schulte
2014-01-17 19:01 ` Rick Frankel
2014-01-17 19:27 ` Achim Gratz
2014-01-18 17:26 ` Eric Schulte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppnqpwhf.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=rick@rickster.com \
--cc=schulte.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).