From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch, ox-latex] better hyperref and title options
Date: Thu, 19 Feb 2015 10:24:59 +0100 [thread overview]
Message-ID: <87pp96nthw.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87mw4asncv.fsf@gmx.us> (rasmus@gmx.us's message of "Thu, 19 Feb 2015 02:26:24 +0100")
Rasmus <rasmus@gmx.us> writes:
> So irrespective of this, here's an updated patch that uses
> secondary-string parsing. Should I add it to master before or after I get
> done with this moving description and keywords?
You can go ahead, after fixing some minor typos. Thanks.
> * ox-latex.el (org-latex-format-spec): New function with format-specs.
Typo in the name.
> (org-latex-template): Use org-latex-format-spec.
> (org-latex-hyperref-template): New defaults and use
> org-latex-format-spec.
> (org-latex-title-command): Use org-latex-format-spec.
Ditto (x3).
> +*** ~org-latex-hyperref-template~, ~org-latex-title-command~ formatting
> +New formatting keys are supported. See ~org-latex-format-spec~.
See docstrings for more information (no need to talk about
`org-latex--format-spec').
> +(defun org-latex--format-spec (info)
> + "Create a format-spec for e.g. `org-latex-hyperref-template'.
> +Also used by `org-latex-title-command'
"Create a format-spec for document meta-data.
INFO is.."
is enough IMO.
> - (let ((title (org-export-data (plist-get info :title) info)))
> + (let ((title (org-export-data (plist-get info :title) info))
> + (spec (when (org-some 'stringp (list org-latex-hyperref-template
> + org-latex-title-command))
> + (org-latex--format-spec info))))
Nitpick: #'stringp
Anyway, both `org-latex-hyperref-template' and `org-latex-title-command'
are always strings, per defcustom type. So you can drop the `when' part:
(spec (org-latex--format-spec info))
Regards,
next prev parent reply other threads:[~2015-02-19 9:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 0:39 [patch, ox-latex] better hyperref and title options Rasmus
2015-02-12 23:59 ` Nicolas Goaziou
2015-02-15 1:53 ` Rasmus
2015-02-15 10:49 ` Nicolas Goaziou
2015-02-15 11:42 ` Rasmus
2015-02-15 12:57 ` Nicolas Goaziou
2015-02-15 13:11 ` Rasmus
2015-02-15 15:57 ` Nicolas Goaziou
2015-02-15 16:55 ` Rasmus
2015-02-19 1:26 ` Rasmus
2015-02-19 9:24 ` Nicolas Goaziou [this message]
2015-02-19 21:43 ` Rasmus
2015-02-19 22:58 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pp96nthw.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).