From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Phil Hudson <phil.hudson@iname.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH 2/2] org-capture.el: Support all target file specifiction variants in Customize
Date: Fri, 13 May 2016 18:11:46 +0200 [thread overview]
Message-ID: <87posq7xa5.fsf@saiph.selenimh> (raw)
In-Reply-To: <87vb2k450b.fsf@quiz.hudson-it.ddns.net> (Phil Hudson's message of "Wed, 11 May 2016 23:13:56 +0100")
Hello,
Phil Hudson <phil.hudson@iname.com> writes:
> From 9ca987e6580ef633c961bf2023813d8544a0d36b Mon Sep 17 00:00:00 2001
> From: Phil Hudson <phil.hudson@iname.com>
> Date: Wed, 11 May 2016 22:49:01 +0100
> Subject: [PATCH 2/2] org-capture.el: Support all target file specifiction
> variants in Customize
I cannot apply this patch. Could you rebase against maint and try
sending it again? Thank you.
> (const :format "" file)
> - (file :tag " File"))
> + (choice :tag " Filename"
> + (file :tag " Literal")
> + (function :tag " Function")
> + (variable :tag " Variable")
> + (sexp :tag " Form")))
I think you can remove all most of the redundancy using backquote, e.g.,
(let ((file-sources '(choice :tag " Filename"
(file :tag " Literal")
(function :tag " Function")
(variable :tag " Variable")
(sexp :tag " Form"))))
`(repeat
...
(choice :tag "Target location"
(const :format "" file)
,file-sources)
...))
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2016-05-13 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 22:13 [PATCH 2/2] org-capture.el: Support all target file specifiction variants in Customize Phil Hudson
2016-05-13 16:11 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87posq7xa5.fsf@saiph.selenimh \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=phil.hudson@iname.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).