emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Don March <don@donmarch.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Reschedule "++" repeaters on same day if in future
Date: Thu, 30 Jun 2016 14:16:06 +0200	[thread overview]
Message-ID: <87poqy27p5.fsf@saiph.selenimh> (raw)
In-Reply-To: <CABSfPErH7wAAwuQRkuppyQz1txYx-mUjDM5vDJvAZw35yC_aPQ@mail.gmail.com> (Don March's message of "Mon, 27 Jun 2016 02:49:09 -0400")

Hello,

Don March <don@donmarch.net> writes:

> If you have a task with the following timestamp:
>
>     SCHEDULED: <2016-06-19 Sun 21:00 ++1w>
>
> then marking it as DONE at [2016-06-27 at 07:00] should (debatably)
> result in

ISYM [2016-06-26 at 07:00].

>     SCHEDULED: <2016-06-26 Sun 21:00 ++1w>
>
> but instead it becomes
>
>     SCHEDULED: <2016-07-03 Sun 21:00 ++1w>

With the correction above, it makes sense, indeed.

> -				     (<= (time-to-days time)
> -					 (time-to-days (current-time))))
> +				     (or (time-less-p time (current-time))
> +					 (equal time (current-time))))

You should merge both `or'. Also, (equal time (current-time)) is always
nil since they don't have the same structure.

You could write instead

  (while (or (= nshift 0)
             (not (time-less-p (current-time) time)))
    ...)

It would be nice to add an explanation along with an example about that
in the manual, too. WDYT?

Thank you for your patch.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2016-06-30 12:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27  6:49 [PATCH] Reschedule "++" repeaters on same day if in future Don March
2016-06-30 12:16 ` Nicolas Goaziou [this message]
2016-06-30 23:07   ` Don March
2016-07-01  9:27     ` Nicolas Goaziou
2016-07-01 16:30       ` Don March
2016-07-01 17:33         ` Nicolas Goaziou
2016-07-02  6:45           ` Don March
2016-07-02 22:24             ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87poqy27p5.fsf@saiph.selenimh \
    --to=mail@nicolasgoaziou.fr \
    --cc=don@donmarch.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).