From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jack Henahan <jhenahan@me.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: `org-clock--oldest-date` performance
Date: Sat, 20 Jan 2018 12:14:52 +0100 [thread overview]
Message-ID: <87po64ok7n.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m1zi59xbqs.fsf@me.com> (Jack Henahan's message of "Sat, 20 Jan 2018 01:52:59 -0500")
Hello,
Jack Henahan <jhenahan@me.com> writes:
> I've run into a performance issue in `org-clock` which I've narrowed
> down to being caused by the calculation in the defconst for
> `org-clock--oldest-date`. In particular, invoking `org-clock-in` or
> eagerly loading `org-clock` on init incurs a 21(!) second delay while
> calculating the constant. If I inline the value (`(-1034058236842
> -45726)`, in my case), the delay vanishes.
>
> So, context out of the way (just in case someone else already knows an
> easier fix), I'd like to spend some spare cycles finding a better way to
> go about the functionality this is meant to provide. If I've read the
> source correctly, it's meant to provide a view of all the clocks by
> showing all clocks between some time way in the past until now.
A correct fix would be to remove `org-clock--oldest-date', which is used
only in one place, and replace it with nil. Then all
`org-clock-special-range' callers need to be updated to handle this nil
start value.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-01-20 11:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 6:52 `org-clock--oldest-date` performance Jack Henahan
2018-01-20 11:14 ` Nicolas Goaziou [this message]
2018-01-20 17:00 ` [PATCH] " Jack Henahan
2018-01-20 17:05 ` Jack Henahan
2018-01-20 17:09 ` Jack Henahan
2018-01-20 18:18 ` Nicolas Goaziou
2018-01-20 20:32 ` Jack Henahan
2018-01-20 21:06 ` Jack Henahan
2018-01-21 9:42 ` Nicolas Goaziou
2018-01-21 16:04 ` Jack Henahan
2018-01-21 22:30 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po64ok7n.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=jhenahan@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).