emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Yuri Lensky <ydl@ydl.cm>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [Patch] Do not ignore headers argument in ob-latex
Date: Sun, 10 May 2020 14:56:01 +0200	[thread overview]
Message-ID: <87pnbcymn2.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAC38U-cRz1aWf24wgvZOSz80TVw36SBxhTfGcrzKQLJ9DYDL2g@mail.gmail.com> (Yuri Lensky's message of "Sat, 9 May 2020 13:12:57 -0700")

Hello,

Yuri Lensky <ydl@ydl.cm> writes:

> I have updated the attached patch to use `mapconcat' as requested.
> `org-format-latex-header' is already declared earlier in ob-latex.el.

I fixed the commit message and applied the patch. Thank you.

> I am not sure what kind of test you have in mind, since this feature isn't
> completely internal to org-mode. For example, the preview compiles but the
> produced PDF is incorrect before this fix, and I believe the org preview
> machinery ignores errors from the latex compiler.

I was thinking about regression testing `org-babel-execute:latex'. But
it may not make much sense, indeed.

Regards,

-- 
Nicolas Goaziou


      reply	other threads:[~2020-05-10 12:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 20:04 Yuri Lensky
2020-05-07 20:09 ` Nicolas Goaziou
2020-05-09 20:12   ` Yuri Lensky
2020-05-10 12:56     ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnbcymn2.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=ydl@ydl.cm \
    --subject='Re: [Patch] Do not ignore headers argument in ob-latex' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).